QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable rule jsx-curly-brace-presence (#10869)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2020-09-14 19:44:03 +02:00
committed by GitHub
parent c5193ca018
commit a75c36281d
9 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/src/explore/components/ControlHeader.jsx
View File

@@ -100,7 +100,7 @@ export default class ControlHeader extends React.Component {
<OverlayTrigger
placement="top"
overlay={
<Tooltip id={'error-tooltip'}>{this.props.warning}</Tooltip>
<Tooltip id="error-tooltip">{this.props.warning}</Tooltip>
}
>
<i className="fa fa-exclamation-circle text-warning" />
@@ -112,7 +112,7 @@ export default class ControlHeader extends React.Component {
<OverlayTrigger
placement="top"
overlay={
<Tooltip id={'error-tooltip'}>{this.props.danger}</Tooltip>
<Tooltip id="error-tooltip">{this.props.danger}</Tooltip>
}
>
<i className="fa fa-exclamation-circle text-danger" />
@@ -124,7 +124,7 @@ export default class ControlHeader extends React.Component {
<OverlayTrigger
placement="top"
overlay={
<Tooltip id={'error-tooltip'}>
<Tooltip id="error-tooltip">
{this.props.validationErrors.join(' ')}
</Tooltip>
}

2
superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
View File

@@ -125,7 +125,7 @@ export default function QueryAndSaveBtns({
<OverlayTrigger
placement="right"
overlay={
<Tooltip id={'query-error-tooltip'}>{errorMessage}</Tooltip>
<Tooltip id="query-error-tooltip">{errorMessage}</Tooltip>
}
>
<i className="fa fa-exclamation-circle text-danger fa-lg" />

10
superset-frontend/src/explore/components/controls/AnnotationLayer.jsx
View File

@@ -454,7 +454,7 @@ export default class AnnotationLayer extends React.PureComponent {
? 'Interval Start column'
: 'Event Time Column'
}
description={'This column must contain date/time information.'}
description="This column must contain date/time information."
validationErrors={!timeColumn ? ['Mandatory'] : []}
clearable={false}
options={timeColumnOptions}
@@ -467,7 +467,7 @@ export default class AnnotationLayer extends React.PureComponent {
hovered
name="annotation-layer-intervalEnd"
label="Interval End column"
description={'This column must contain date/time information.'}
description="This column must contain date/time information."
validationErrors={!intervalEndColumn ? ['Mandatory'] : []}
options={columns}
value={intervalEndColumn}
@@ -478,7 +478,7 @@ export default class AnnotationLayer extends React.PureComponent {
hovered
name="annotation-layer-title"
label="Title Column"
description={'Pick a title for you annotation.'}
description="Pick a title for you annotation."
options={[{ value: '', label: 'None' }].concat(columns)}
value={titleColumn}
onChange={v => this.setState({ titleColumn: v })}
@@ -643,7 +643,7 @@ export default class AnnotationLayer extends React.PureComponent {
hovered
name="annotation-layer-show-markers"
label="Show Markers"
description={'Shows or hides markers for the time series'}
description="Shows or hides markers for the time series"
value={showMarkers}
onChange={v => this.setState({ showMarkers: v })}
/>
@@ -653,7 +653,7 @@ export default class AnnotationLayer extends React.PureComponent {
hovered
name="annotation-layer-hide-line"
label="Hide Line"
description={'Hides the Line for the time series'}
description="Hides the Line for the time series"
value={hideLine}
onChange={v => this.setState({ hideLine: v })}
/>

2
superset-frontend/src/explore/components/controls/DatasourceControl.jsx
View File

@@ -170,7 +170,7 @@ class DatasourceControl extends React.PureComponent {
<OverlayTrigger
placement="right"
overlay={
<Tooltip id={'toggle-datasource-tooltip'}>
<Tooltip id="toggle-datasource-tooltip">
{t('Expand/collapse datasource configuration')}
</Tooltip>
}