feat: Better return messages in SQL Editor (#14381)

* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* moving migration to separate PR

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* result set

* first draft

* revisions

* made user required prop, added it to all places ResultSet is imported

* changed QueryTable test to allow for useSelector

* Query Table working

* working with heights

* fixed scrolling

* got rid of animated

* fixed tests, revisions

* revisions

* revisions

* heights

* fun with heights

* alert state

* aaron helped me fix this

* better alert messages

* fixed result set test

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
This commit is contained in:
AAfghahi
2021-05-18 14:02:06 -04:00
committed by GitHub
parent 5776dcb61a
commit a7a011cce5
12 changed files with 202 additions and 46 deletions

View File

@@ -83,8 +83,10 @@ const JSON_TREE_THEME = {
};
const StyledFilterableTable = styled.div`
height: 100%;
overflow-x: auto;
margin-top: ${({ theme }) => theme.gridUnit * 2}px;
overflow-y: hidden;
`;
// when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
@@ -466,7 +468,6 @@ export default class FilterableTable extends PureComponent<
<ScrollSync>
{({ onScroll, scrollTop }) => (
<div
style={{ height }}
className="filterable-table-container Table"
data-test="filterable-table-container"
ref={this.container}
@@ -559,7 +560,6 @@ export default class FilterableTable extends PureComponent<
this.getDatum(sortedAndFilteredList, index);
return (
<StyledFilterableTable
style={{ height }}
className="filterable-table-container"
ref={this.container}
>