fix: Edit physical dataset from the Edit Dataset modal (#15770)

* Remove unnecessary onChange

* Remove confliciting onChange

* Revert unnecessary change

* Enhance and fix tests
This commit is contained in:
Geido
2021-07-19 20:39:01 +02:00
committed by GitHub
parent 239336c3e8
commit a7cbcde9bf
4 changed files with 13 additions and 13 deletions

View File

@@ -72,7 +72,7 @@ interface DatabaseSelectorProps {
readOnly?: boolean;
schema?: string;
sqlLabMode?: boolean;
onChange?: ({
onUpdate?: ({
dbId,
schema,
}: {
@@ -89,7 +89,7 @@ export default function DatabaseSelector({
getTableList,
handleError,
isDatabaseSelectEnabled = true,
onChange,
onUpdate,
onDbChange,
onSchemaChange,
onSchemasLoad,
@@ -143,8 +143,8 @@ export default function DatabaseSelector({
function onSelectChange({ dbId, schema }: { dbId: number; schema?: string }) {
setCurrentDbId(dbId);
setCurrentSchema(schema);
if (onChange) {
onChange({ dbId, schema, tableName: undefined });
if (onUpdate) {
onUpdate({ dbId, schema, tableName: undefined });
}
}