QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mypy] Disallowing implicit optional (#9150)

Browse Source
This commit is contained in:
John Bodley
2020-02-16 22:34:16 -08:00
committed by GitHub
parent 114642d78c
commit a7e433a512
15 changed files with 39 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset/models/core.py
View File

@@ -429,7 +429,7 @@ class Database(
attribute_in_key="id",
)
def get_all_table_names_in_database(
self, cache: bool = False, cache_timeout: bool = None, force=False
self, cache: bool = False, cache_timeout: Optional[bool] = None, force=False
) -> List[utils.DatasourceName]:
"""Parameters need to be passed as keyword arguments."""
if not self.allow_multi_schema_metadata_fetch:
@@ -441,7 +441,10 @@ class Database(
attribute_in_key="id", # type: ignore
)
def get_all_view_names_in_database(
self, cache: bool = False, cache_timeout: bool = None, force: bool = False
self,
cache: bool = False,
cache_timeout: Optional[bool] = None,
force: bool = False,
) -> List[utils.DatasourceName]:
"""Parameters need to be passed as keyword arguments."""
if not self.allow_multi_schema_metadata_fetch:
@@ -514,7 +517,10 @@ class Database(
key=lambda *args, **kwargs: "db:{}:schema_list", attribute_in_key="id"
)
def get_all_schema_names(
self, cache: bool = False, cache_timeout: int = None, force: bool = False
self,
cache: bool = False,
cache_timeout: Optional[int] = None,
force: bool = False,
) -> List[str]:
"""Parameters need to be passed as keyword arguments.