QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enable lint PT009 'use regular assert over self.assert.*' (#30521)

Browse Source
This commit is contained in:
Maxime Beauchemin
2024-10-07 13:17:27 -07:00
committed by GitHub
parent 1f013055d2
commit a849c29288
62 changed files with 2218 additions and 2422 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/integration_tests/dashboards/dao_tests.py
View File

@@ -87,12 +87,12 @@ class TestDashboardDAO(SupersetTestCase):
"duplicate_slices": False,
}
dash = DashboardDAO.copy_dashboard(original_dash, dash_data)
self.assertNotEqual(dash.id, original_dash.id)
self.assertEqual(len(dash.position), len(original_dash.position))
self.assertEqual(dash.dashboard_title, "copied dash")
self.assertEqual(dash.css, "<css>")
self.assertEqual(dash.owners, [security_manager.find_user("admin")])
self.assertCountEqual(dash.slices, original_dash.slices)
assert dash.id != original_dash.id
assert len(dash.position) == len(original_dash.position)
assert dash.dashboard_title == "copied dash"
assert dash.css == "<css>"
assert dash.owners == [security_manager.find_user("admin")]
self.assertCountEqual(dash.slices, original_dash.slices) # noqa: PT009
db.session.delete(dash)
db.session.commit()
@@ -118,9 +118,7 @@ class TestDashboardDAO(SupersetTestCase):
"duplicate_slices": False,
}
dash = DashboardDAO.copy_dashboard(original_dash, dash_data)
self.assertEqual(
dash.params_dict["native_filter_configuration"], [{"mock": "filter"}]
)
assert dash.params_dict["native_filter_configuration"] == [{"mock": "filter"}]
db.session.delete(dash)
db.session.commit()
@@ -141,15 +139,15 @@ class TestDashboardDAO(SupersetTestCase):
"duplicate_slices": True,
}
dash = DashboardDAO.copy_dashboard(original_dash, dash_data)
self.assertNotEqual(dash.id, original_dash.id)
self.assertEqual(len(dash.position), len(original_dash.position))
self.assertEqual(dash.dashboard_title, "copied dash")
self.assertEqual(dash.css, "<css>")
self.assertEqual(dash.owners, [security_manager.find_user("admin")])
self.assertEqual(len(dash.slices), len(original_dash.slices))
assert dash.id != original_dash.id
assert len(dash.position) == len(original_dash.position)
assert dash.dashboard_title == "copied dash"
assert dash.css == "<css>"
assert dash.owners == [security_manager.find_user("admin")]
assert len(dash.slices) == len(original_dash.slices)
for original_slc in original_dash.slices:
for slc in dash.slices:
self.assertNotEqual(slc.id, original_slc.id)
assert slc.id != original_slc.id
for slc in dash.slices:
db.session.delete(slc)