QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: use shorten url in standalone iframe (#10651)

Browse Source
This commit is contained in:
Grace Guo
2020-08-21 15:27:15 -07:00
committed by GitHub
parent b86c0e5727
commit aa8ff8759c
2 changed files with 46 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
superset-frontend/spec/javascripts/explore/components/EmbedCodeButton_spec.jsx
View File

@@ -23,6 +23,7 @@ import sinon from 'sinon';
import EmbedCodeButton from 'src/explore/components/EmbedCodeButton';
import * as exploreUtils from 'src/explore/exploreUtils';
import * as common from 'src/utils/common';
describe('EmbedCodeButton', () => {
const defaultProps = {
@@ -40,14 +41,32 @@ describe('EmbedCodeButton', () => {
expect(wrapper.find(OverlayTrigger)).toExist();
});
it('returns correct embed code', () => {
const stub = sinon
.stub(exploreUtils, 'getExploreLongUrl')
.callsFake(() => 'endpoint_url');
it('should create shorten, standalone, explore url', () => {
const spy1 = sinon.spy(exploreUtils, 'getExploreLongUrl');
const spy2 = sinon.spy(common, 'getShortUrl');
const wrapper = mount(<EmbedCodeButton {...defaultProps} />);
wrapper.setState({
height: '1000',
width: '2000',
shortUrl: 'http://localhostendpoint_url&height=1000',
});
const trigger = wrapper.find(OverlayTrigger);
trigger.simulate('click');
expect(spy1.args[0][1]).toBe('standalone');
expect(spy2.callCount).toBe(1);
spy1.restore();
spy2.restore();
});
it('returns correct embed code', () => {
const wrapper = mount(<EmbedCodeButton {...defaultProps} />);
wrapper.setState({
height: '1000',
width: '2000',
shortUrl: 'http://localhostendpoint_url&height=1000',
});
const embedHTML =
'<iframe\n' +
@@ -60,6 +79,5 @@ describe('EmbedCodeButton', () => {
'>\n' +
'</iframe>';
expect(wrapper.instance().generateEmbedHTML()).toBe(embedHTML);
stub.restore();
});
});