Re-add dashboard short links (#5398)

* Re-add dashboard short links

* Make the short link available to all users
* Include filters in the short link for dashboards

* Remove duplicate key causing linter error

* Change URL Short link button into a menu item with Modal

* Split out tests, bind URL short link in constructor

superset/assets/spec/javascripts/components/URLShortLinkModal_spec.jsx

@@ -0,0 +1,27 @@
+import React from 'react';
+import configureStore from 'redux-mock-store';
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { shallow } from 'enzyme';
+
+import URLShortLinkModal from '../../../src/components/URLShortLinkModal';
+import ModalTrigger from '../../../src/components/ModalTrigger';
+
+describe('URLShortLinkModal', () => {
+  const defaultProps = {
+    url: 'mockURL',
+    emailSubject: 'Mock Subject',
+    emailContent: 'mock content',
+  };
+
+  function setup() {
+    const mockStore = configureStore([]);
+    const store = mockStore({});
+    return shallow(<URLShortLinkModal {...defaultProps} />, { context: { store } }).dive();
+  }
+
+  it('renders ModalTrigger', () => {
+    const wrapper = setup();
+    expect(wrapper.find(ModalTrigger)).have.length(1);
+  });
+});

superset/assets/spec/javascripts/dashboard/components/HeaderActionsDropdown_spec.jsx

@@ -0,0 +1,141 @@
+import React from 'react';
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { shallow } from 'enzyme';
+import { DropdownButton, MenuItem } from 'react-bootstrap';
+import RefreshIntervalModal from '../../../../src/dashboard/components/RefreshIntervalModal';
+import URLShortLinkModal from '../../../../src/components/URLShortLinkModal';
+import HeaderActionsDropdown from '../../../../src/dashboard/components/HeaderActionsDropdown';
+import SaveModal from '../../../../src/dashboard/components/SaveModal';
+import CssEditor from '../../../../src/dashboard/components/CssEditor';
+
+describe('HeaderActionsDropdown', () => {
+  const props = {
+    addSuccessToast: () => {},
+    addDangerToast: () => {},
+    dashboardId: 1,
+    dashboardTitle: 'Title',
+    hasUnsavedChanges: false,
+    css: '',
+    onChange: () => {},
+    updateCss: () => {},
+    forceRefreshAllCharts: () => {},
+    startPeriodicRender: () => {},
+    editMode: false,
+    userCanEdit: false,
+    userCanSave: false,
+    layout: {},
+    filters: {},
+    expandedSlices: {},
+    onSave: () => {},
+  };
+
+  function setup(overrideProps) {
+    const wrapper = shallow(
+      <HeaderActionsDropdown {...props} {...overrideProps} />,
+    );
+    return wrapper;
+  }
+
+  describe('readonly-user', () => {
+    const overrideProps = { userCanSave: false };
+
+    it('should render the DropdownButton', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(DropdownButton)).to.have.lengthOf(1);
+    });
+
+    it('should not render the SaveModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(SaveModal)).to.have.lengthOf(0);
+    });
+
+    it('should render one MenuItem', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(MenuItem)).to.have.lengthOf(1);
+    });
+
+    it('should render the RefreshIntervalModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(RefreshIntervalModal)).to.have.lengthOf(1);
+    });
+
+    it('should render the URLShortLinkModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(URLShortLinkModal)).to.have.lengthOf(1);
+    });
+
+    it('should not render the CssEditor', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(CssEditor)).to.have.lengthOf(0);
+    });
+  });
+
+  describe('write-user', () => {
+    const overrideProps = { userCanSave: true };
+
+    it('should render the DropdownButton', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(DropdownButton)).to.have.lengthOf(1);
+    });
+
+    it('should render the SaveModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(SaveModal)).to.have.lengthOf(1);
+    });
+
+    it('should render two MenuItems', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(MenuItem)).to.have.lengthOf(2);
+    });
+
+    it('should render the RefreshIntervalModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(RefreshIntervalModal)).to.have.lengthOf(1);
+    });
+
+    it('should render the URLShortLinkModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(URLShortLinkModal)).to.have.lengthOf(1);
+    });
+
+    it('should not render the CssEditor', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(CssEditor)).to.have.lengthOf(0);
+    });
+  });
+
+  describe('write-user-with-edit-mode', () => {
+    const overrideProps = { userCanSave: true, editMode: true };
+
+    it('should render the DropdownButton', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(DropdownButton)).to.have.lengthOf(1);
+    });
+
+    it('should render the SaveModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(SaveModal)).to.have.lengthOf(1);
+    });
+
+    it('should render three MenuItems', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(MenuItem)).to.have.lengthOf(3);
+    });
+
+    it('should render the RefreshIntervalModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(RefreshIntervalModal)).to.have.lengthOf(1);
+    });
+
+    it('should render the URLShortLinkModal', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(URLShortLinkModal)).to.have.lengthOf(1);
+    });
+
+    it('should render the CssEditor', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(CssEditor)).to.have.lengthOf(1);
+    });
+  });
+});

superset/assets/spec/javascripts/dashboard/components/Header_spec.jsx

@@ -0,0 +1,147 @@
+import React from 'react';
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { shallow } from 'enzyme';
+import Header from '../../../../src/dashboard/components/Header';
+import EditableTitle from '../../../../src/components/EditableTitle';
+import FaveStar from '../../../../src/components/FaveStar';
+import HeaderActionsDropdown from '../../../../src/dashboard/components/HeaderActionsDropdown';
+import Button from '../../../../src/components/Button';
+import UndoRedoKeylisteners from '../../../../src/dashboard/components/UndoRedoKeylisteners';
+
+describe('Header', () => {
+  const props = {
+    addSuccessToast: () => {},
+    addDangerToast: () => {},
+    dashboardInfo: { id: 1, dash_edit_perm: true, dash_save_perm: true },
+    dashboardTitle: 'title',
+    charts: {},
+    layout: {},
+    filters: {},
+    expandedSlices: {},
+    css: '',
+    isStarred: false,
+    onSave: () => {},
+    onChange: () => {},
+    fetchFaveStar: () => {},
+    fetchCharts: () => {},
+    saveFaveStar: () => {},
+    startPeriodicRender: () => {},
+    updateDashboardTitle: () => {},
+    editMode: false,
+    setEditMode: () => {},
+    showBuilderPane: false,
+    toggleBuilderPane: () => {},
+    updateCss: () => {},
+    hasUnsavedChanges: false,
+    maxUndoHistoryExceeded: false,
+
+    // redux
+    onUndo: () => {},
+    onRedo: () => {},
+    undoLength: 0,
+    redoLength: 0,
+    setMaxUndoHistoryExceeded: () => {},
+    maxUndoHistoryToast: () => {},
+  };
+
+  function setup(overrideProps) {
+    const wrapper = shallow(<Header {...props} {...overrideProps} />);
+    return wrapper;
+  }
+
+  describe('read-only-user', () => {
+    const overrideProps = {
+      dashboardInfo: { id: 1, dash_edit_perm: false, dash_save_perm: false },
+    };
+
+    it('should render the EditableTitle', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(EditableTitle)).to.have.lengthOf(1);
+    });
+
+    it('should render the FaveStar', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(FaveStar)).to.have.lengthOf(1);
+    });
+
+    it('should render the HeaderActionsDropdown', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(HeaderActionsDropdown)).to.have.lengthOf(1);
+    });
+
+    it('should render one Button', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(Button)).to.have.lengthOf(1);
+    });
+
+    it('should not set up undo/redo', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(UndoRedoKeylisteners)).to.have.lengthOf(0);
+    });
+  });
+
+  describe('write-user', () => {
+    const overrideProps = {
+      editMode: false,
+      dashboardInfo: { id: 1, dash_edit_perm: true, dash_save_perm: true },
+    };
+
+    it('should render the EditableTitle', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(EditableTitle)).to.have.lengthOf(1);
+    });
+
+    it('should render the FaveStar', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(FaveStar)).to.have.lengthOf(1);
+    });
+
+    it('should render the HeaderActionsDropdown', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(HeaderActionsDropdown)).to.have.lengthOf(1);
+    });
+
+    it('should render one Button', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(Button)).to.have.lengthOf(1);
+    });
+
+    it('should not set up undo/redo', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(UndoRedoKeylisteners)).to.have.lengthOf(0);
+    });
+  });
+
+  describe('write-user-with-edit-mode', () => {
+    const overrideProps = {
+      editMode: true,
+      dashboardInfo: { id: 1, dash_edit_perm: true, dash_save_perm: true },
+    };
+
+    it('should render the EditableTitle', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(EditableTitle)).to.have.lengthOf(1);
+    });
+
+    it('should render the FaveStar', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(FaveStar)).to.have.lengthOf(1);
+    });
+
+    it('should render the HeaderActionsDropdown', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(HeaderActionsDropdown)).to.have.lengthOf(1);
+    });
+
+    it('should render four Buttons', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(Button)).to.have.lengthOf(4);
+    });
+
+    it('should set up undo/redo', () => {
+      const wrapper = setup(overrideProps);
+      expect(wrapper.find(UndoRedoKeylisteners)).to.have.lengthOf(1);
+    });
+  });
+});

superset/assets/spec/javascripts/dashboard/util/getDashboardUrl_spec.js

@@ -0,0 +1,14 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+
+import getDashboardUrl from '../../../../src/dashboard/util/getDashboardUrl';
+
+describe('getChartIdsFromLayout', () => {
+  it('should encode filters', () => {
+    const filters = { 35: { key: ['value'] } };
+    const url = getDashboardUrl('path', filters);
+    expect(url).to.equal(
+      'path?preselect_filters=%7B%2235%22%3A%7B%22key%22%3A%5B%22value%22%5D%7D%7D',
+    );
+  });
+});