QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-06 16:19:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sqllab] slide animations when adding/removing/toggling TableElement (#1472)

Browse Source 
* [sqllab] slide animations when adding/removing/toggling TableElement

* Adressing comments
This commit is contained in:
Maxime Beauchemin
2016-10-29 07:48:17 -07:00
committed by GitHub
parent 4bf525222a
commit ab083b86f3
6 changed files with 135 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
caravel/assets/javascripts/SqlLab/components/CopyQueryTabUrl.jsx
View File

@@ -3,11 +3,7 @@ import CopyToClipboard from '../../components/CopyToClipboard';
import { getShortUrl } from '../../../utils/common';
const propTypes = {
queryEditor: React.PropTypes.object,
};
const defaultProps = {
queryEditor: null,
queryEditor: React.PropTypes.object.isRequired,
};
export default class CopyQueryTabUrl extends React.PureComponent {
@@ -19,8 +15,8 @@ export default class CopyQueryTabUrl extends React.PureComponent {
}
componentWillMount() {
const params = [];
const qe = this.props.queryEditor;
const params = [];
if (qe.dbId) params.push('dbid=' + qe.dbId);
if (qe.title) params.push('title=' + encodeURIComponent(qe.title));
if (qe.schema) params.push('schema=' + encodeURIComponent(qe.schema));
@@ -52,4 +48,3 @@ export default class CopyQueryTabUrl extends React.PureComponent {
}
CopyQueryTabUrl.propTypes = propTypes;
CopyQueryTabUrl.defaultProps = defaultProps;