mirror of
https://github.com/apache/superset.git
synced 2026-04-21 00:54:44 +00:00
[flake8] Resolving Q??? errors (#3847)
This commit is contained in:
John Bodley
committed by
Maxime Beauchemin
Maxime Beauchemin
parent
630604bc6b
commit
ac57780607
@@ -23,47 +23,47 @@ class PickableMock(Mock):
|
||||
|
||||
|
||||
SEGMENT_METADATA = [{
|
||||
"id": "some_id",
|
||||
"intervals": ["2013-05-13T00:00:00.000Z/2013-05-14T00:00:00.000Z"],
|
||||
"columns": {
|
||||
"__time": {
|
||||
"type": "LONG", "hasMultipleValues": False,
|
||||
"size": 407240380, "cardinality": None, "errorMessage": None},
|
||||
"dim1": {
|
||||
"type": "STRING", "hasMultipleValues": False,
|
||||
"size": 100000, "cardinality": 1944, "errorMessage": None},
|
||||
"dim2": {
|
||||
"type": "STRING", "hasMultipleValues": True,
|
||||
"size": 100000, "cardinality": 1504, "errorMessage": None},
|
||||
"metric1": {
|
||||
"type": "FLOAT", "hasMultipleValues": False,
|
||||
"size": 100000, "cardinality": None, "errorMessage": None},
|
||||
'id': 'some_id',
|
||||
'intervals': ['2013-05-13T00:00:00.000Z/2013-05-14T00:00:00.000Z'],
|
||||
'columns': {
|
||||
'__time': {
|
||||
'type': 'LONG', 'hasMultipleValues': False,
|
||||
'size': 407240380, 'cardinality': None, 'errorMessage': None},
|
||||
'dim1': {
|
||||
'type': 'STRING', 'hasMultipleValues': False,
|
||||
'size': 100000, 'cardinality': 1944, 'errorMessage': None},
|
||||
'dim2': {
|
||||
'type': 'STRING', 'hasMultipleValues': True,
|
||||
'size': 100000, 'cardinality': 1504, 'errorMessage': None},
|
||||
'metric1': {
|
||||
'type': 'FLOAT', 'hasMultipleValues': False,
|
||||
'size': 100000, 'cardinality': None, 'errorMessage': None},
|
||||
},
|
||||
"aggregators": {
|
||||
"metric1": {
|
||||
"type": "longSum",
|
||||
"name": "metric1",
|
||||
"fieldName": "metric1"},
|
||||
'aggregators': {
|
||||
'metric1': {
|
||||
'type': 'longSum',
|
||||
'name': 'metric1',
|
||||
'fieldName': 'metric1'},
|
||||
},
|
||||
"size": 300000,
|
||||
"numRows": 5000000,
|
||||
'size': 300000,
|
||||
'numRows': 5000000,
|
||||
}]
|
||||
|
||||
GB_RESULT_SET = [
|
||||
{
|
||||
"version": "v1",
|
||||
"timestamp": "2012-01-01T00:00:00.000Z",
|
||||
"event": {
|
||||
"dim1": 'Canada',
|
||||
"metric1": 12345678,
|
||||
'version': 'v1',
|
||||
'timestamp': '2012-01-01T00:00:00.000Z',
|
||||
'event': {
|
||||
'dim1': 'Canada',
|
||||
'metric1': 12345678,
|
||||
},
|
||||
},
|
||||
{
|
||||
"version": "v1",
|
||||
"timestamp": "2012-01-01T00:00:00.000Z",
|
||||
"event": {
|
||||
"dim1": 'USA',
|
||||
"metric1": 12345678 / 2,
|
||||
'version': 'v1',
|
||||
'timestamp': '2012-01-01T00:00:00.000Z',
|
||||
'event': {
|
||||
'dim1': 'USA',
|
||||
'metric1': 12345678 / 2,
|
||||
},
|
||||
},
|
||||
]
|
||||
@@ -122,7 +122,7 @@ class DruidTests(SupersetTestCase):
|
||||
|
||||
resp = self.get_resp('/superset/explore/druid/{}/'.format(
|
||||
datasource_id))
|
||||
self.assertIn("test_datasource", resp)
|
||||
self.assertIn('test_datasource', resp)
|
||||
form_data = {
|
||||
'viz_type': 'table',
|
||||
'granularity': 'one+day',
|
||||
@@ -141,7 +141,7 @@ class DruidTests(SupersetTestCase):
|
||||
datasource_id, json.dumps(form_data))
|
||||
)
|
||||
resp = self.get_json_resp(url)
|
||||
self.assertEqual("Canada", resp['data']['records'][0]['dim1'])
|
||||
self.assertEqual('Canada', resp['data']['records'][0]['dim1'])
|
||||
|
||||
form_data = {
|
||||
'viz_type': 'table',
|
||||
@@ -161,7 +161,7 @@ class DruidTests(SupersetTestCase):
|
||||
datasource_id, json.dumps(form_data))
|
||||
)
|
||||
resp = self.get_json_resp(url)
|
||||
self.assertEqual("Canada", resp['data']['records'][0]['dim1'])
|
||||
self.assertEqual('Canada', resp['data']['records'][0]['dim1'])
|
||||
|
||||
def test_druid_sync_from_config(self):
|
||||
CLUSTER_NAME = 'new_druid'
|
||||
@@ -184,19 +184,19 @@ class DruidTests(SupersetTestCase):
|
||||
db.session.commit()
|
||||
|
||||
cfg = {
|
||||
"user": "admin",
|
||||
"cluster": CLUSTER_NAME,
|
||||
"config": {
|
||||
"name": "test_click",
|
||||
"dimensions": ["affiliate_id", "campaign", "first_seen"],
|
||||
"metrics_spec": [{"type": "count", "name": "count"},
|
||||
{"type": "sum", "name": "sum"}],
|
||||
"batch_ingestion": {
|
||||
"sql": "SELECT * FROM clicks WHERE d='{{ ds }}'",
|
||||
"ts_column": "d",
|
||||
"sources": [{
|
||||
"table": "clicks",
|
||||
"partition": "d='{{ ds }}'",
|
||||
'user': 'admin',
|
||||
'cluster': CLUSTER_NAME,
|
||||
'config': {
|
||||
'name': 'test_click',
|
||||
'dimensions': ['affiliate_id', 'campaign', 'first_seen'],
|
||||
'metrics_spec': [{'type': 'count', 'name': 'count'},
|
||||
{'type': 'sum', 'name': 'sum'}],
|
||||
'batch_ingestion': {
|
||||
'sql': "SELECT * FROM clicks WHERE d='{{ ds }}'",
|
||||
'ts_column': 'd',
|
||||
'sources': [{
|
||||
'table': 'clicks',
|
||||
'partition': "d='{{ ds }}'",
|
||||
}],
|
||||
},
|
||||
},
|
||||
@@ -207,13 +207,13 @@ class DruidTests(SupersetTestCase):
|
||||
druid_ds = (
|
||||
db.session
|
||||
.query(DruidDatasource)
|
||||
.filter_by(datasource_name="test_click")
|
||||
.filter_by(datasource_name='test_click')
|
||||
.one()
|
||||
)
|
||||
col_names = set([c.column_name for c in druid_ds.columns])
|
||||
assert {"affiliate_id", "campaign", "first_seen"} == col_names
|
||||
assert {'affiliate_id', 'campaign', 'first_seen'} == col_names
|
||||
metric_names = {m.metric_name for m in druid_ds.metrics}
|
||||
assert {"count", "sum"} == metric_names
|
||||
assert {'count', 'sum'} == metric_names
|
||||
assert resp.status_code == 201
|
||||
|
||||
check()
|
||||
@@ -222,29 +222,29 @@ class DruidTests(SupersetTestCase):
|
||||
|
||||
# datasource exists, add new metrics and dimensions
|
||||
cfg = {
|
||||
"user": "admin",
|
||||
"cluster": CLUSTER_NAME,
|
||||
"config": {
|
||||
"name": "test_click",
|
||||
"dimensions": ["affiliate_id", "second_seen"],
|
||||
"metrics_spec": [
|
||||
{"type": "bla", "name": "sum"},
|
||||
{"type": "unique", "name": "unique"},
|
||||
'user': 'admin',
|
||||
'cluster': CLUSTER_NAME,
|
||||
'config': {
|
||||
'name': 'test_click',
|
||||
'dimensions': ['affiliate_id', 'second_seen'],
|
||||
'metrics_spec': [
|
||||
{'type': 'bla', 'name': 'sum'},
|
||||
{'type': 'unique', 'name': 'unique'},
|
||||
],
|
||||
},
|
||||
}
|
||||
resp = self.client.post('/superset/sync_druid/', data=json.dumps(cfg))
|
||||
druid_ds = db.session.query(DruidDatasource).filter_by(
|
||||
datasource_name="test_click").one()
|
||||
datasource_name='test_click').one()
|
||||
# columns and metrics are not deleted if config is changed as
|
||||
# user could define his own dimensions / metrics and want to keep them
|
||||
assert set([c.column_name for c in druid_ds.columns]) == set(
|
||||
["affiliate_id", "campaign", "first_seen", "second_seen"])
|
||||
['affiliate_id', 'campaign', 'first_seen', 'second_seen'])
|
||||
assert set([m.metric_name for m in druid_ds.metrics]) == set(
|
||||
["count", "sum", "unique"])
|
||||
['count', 'sum', 'unique'])
|
||||
# metric type will not be overridden, sum stays instead of bla
|
||||
assert set([m.metric_type for m in druid_ds.metrics]) == set(
|
||||
["longSum", "sum", "unique"])
|
||||
['longSum', 'sum', 'unique'])
|
||||
assert resp.status_code == 201
|
||||
|
||||
def test_filter_druid_datasource(self):
|
||||
@@ -322,7 +322,7 @@ class DruidTests(SupersetTestCase):
|
||||
|
||||
view_menu_name = cluster.datasources[0].get_perm()
|
||||
view_menu = sm.find_view_menu(view_menu_name)
|
||||
permission = sm.find_permission("datasource_access")
|
||||
permission = sm.find_permission('datasource_access')
|
||||
|
||||
pv = sm.get_session.query(sm.permissionview_model).filter_by(
|
||||
permission=permission, view_menu=view_menu).first()
|
||||
@@ -511,7 +511,7 @@ class DruidTests(SupersetTestCase):
|
||||
self.assertEqual('', res.filter['filter']['value'])
|
||||
|
||||
def test_get_filters_extracts_values_in_quotes(self):
|
||||
filtr = {'col': 'A', 'op': 'in', 'val': [" 'a' "]}
|
||||
filtr = {'col': 'A', 'op': 'in', 'val': [' "a" ']}
|
||||
res = DruidDatasource.get_filters([filtr], [])
|
||||
self.assertEqual('a', res.filter['filter']['value'])
|
||||
|
||||
|
||||
Reference in New Issue
Block a user