QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: simplify error messaging in database modal (#19165)

Browse Source 
* testing for dbconn modal error message

* remove consoles and error alert mapping

* lint fix

* update url message

* add modal fix

* update comments

* fix err msg bugs

* fix pylint

* fix line

* fix tests

* fix assertions
This commit is contained in:
Phillip Kelley-Dotson
2022-04-21 12:44:21 -07:00
committed by GitHub
parent fa680369ea
commit ad715429f9
5 changed files with 31 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/unit_tests/db_engine_specs/test_gsheets.py
View File

@@ -76,7 +76,11 @@ def test_validate_parameters_catalog(
assert errors == [
SupersetError(
message="URL could not be identified",
message=(
"The URL could not be identified. Please check for typos "
"and make sure that ‘Type of Google Sheets allowed’ "
"selection matches the input."
),
error_type=SupersetErrorType.TABLE_DOES_NOT_EXIST_ERROR,
level=ErrorLevel.WARNING,
extra={
@@ -97,7 +101,11 @@ def test_validate_parameters_catalog(
},
),
SupersetError(
message="URL could not be identified",
message=(
"The URL could not be identified. Please check for typos "
"and make sure that ‘Type of Google Sheets allowed’ "
"selection matches the input."
),
error_type=SupersetErrorType.TABLE_DOES_NOT_EXIST_ERROR,
level=ErrorLevel.WARNING,
extra={
@@ -158,7 +166,11 @@ def test_validate_parameters_catalog_and_credentials(
errors = GSheetsEngineSpec.validate_parameters(parameters) # ignore: type
assert errors == [
SupersetError(
message="URL could not be identified",
message=(
"The URL could not be identified. Please check for typos "
"and make sure that ‘Type of Google Sheets allowed’ "
"selection matches the input."
),
error_type=SupersetErrorType.TABLE_DOES_NOT_EXIST_ERROR,
level=ErrorLevel.WARNING,
extra={