mirror of
https://github.com/apache/superset.git
synced 2026-05-30 04:39:20 +00:00
feat(plugin-chart-country-map): ship all 33 NE worldviews at Admin 0
Previously the build only emitted the ukr (Ukraine) worldview, so the worldview dropdown had a single option even though it claimed otherwise. Build now produces Admin 0 GeoJSON for every NE-published editorial: default, arg, bdg, bra, chn, deu, egy, esp, fra, gbr, grc, idn, ind, iso, isr, ita, jpn, kor, mar, nep, nld, pak, pol, prt, pse, rus, sau, swe, tur, twn, ukr, usa, vnm (33 total). NE does not publish per-worldview Admin 1 variants, so subdivisions within a country come from a single shared file. The frontend now always points Admin 1, regional aggregation, and composite URLs at the ukr-prefixed shared outputs regardless of the selected worldview — the worldview control only affects the world (Admin 0) map. - build.py: expand WORLDVIEWS_ADMIN_0 to 33 worldviews; main() builds Admin 0 for all of them, Admin 1 only for ukr - transformProps.ts: introduce SHARED_ADMIN1_WORLDVIEW = 'ukr'; pin all non-Admin-0 URLs to it - controlPanel.tsx: WORLDVIEW_LABELS now covers all 33 codes; unrecognized codes still fall back to raw code for forward-compat - transformProps.test.ts: cover shared-Admin1 contract (admin1+chn still resolves to ukr_admin1_*) - pre-commit: exclude .geo.json from check-added-large-files (existing rule only excluded .geojson and would block these ~2MB worldview files) - README + SIP: document the worldview model and check off Phase 1 item Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -41,6 +41,26 @@ scripts/
|
||||
output/ # gitignored — build artifacts
|
||||
```
|
||||
|
||||
## Worldviews
|
||||
|
||||
Natural Earth publishes per-country editorial variants of its Admin 0
|
||||
(countries) layer: `ne_10m_admin_0_countries_<code>.shp`. Each variant
|
||||
encodes that country's official stance on disputed borders — e.g.
|
||||
`ne_10m_admin_0_countries_ukr.shp` shows Crimea as Ukrainian; `_chn`
|
||||
shows Taiwan as part of China; `_iso` uses neutral ISO 3166-1 boundaries.
|
||||
|
||||
`build.py` builds Admin 0 for every NE-published worldview listed in
|
||||
the `WORLDVIEWS_ADMIN_0` constant — outputs are named
|
||||
`<worldview>_admin0.geo.json`. The plugin's worldview control reads the
|
||||
list from `manifest.json` and shows whatever the build produced.
|
||||
|
||||
NE does **not** publish per-worldview Admin 1 variants — subdivisions
|
||||
within a country come from a single global file. We build Admin 1 once
|
||||
(under the `ukr` filename prefix for back-compat) and the frontend
|
||||
always points Admin 1, regional, and composite URLs at that shared
|
||||
output regardless of which worldview the user has selected. The
|
||||
worldview choice only changes the country-borders map (Admin 0).
|
||||
|
||||
## Operating principles
|
||||
|
||||
- **Default tool: declarative YAML.** Most touchups are renames, repositions, dissolves, or filters — all expressible in YAML. Diffs are small, conflicts localize cleanly to one entry, contributors can submit "fix typo X" as a one-line PR.
|
||||
|
||||
Reference in New Issue
Block a user