QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: implement limit extraction in sqlglot (#33456)

Browse Source
This commit is contained in:
Beto Dealmeida
2025-05-22 20:09:36 -04:00
committed by GitHub
parent 546945e7a6
commit adeed60fe0
3 changed files with 222 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset/commands/sql_lab/export.py
View File

@@ -27,7 +27,7 @@ from superset.commands.base import BaseCommand
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.exceptions import SupersetErrorException, SupersetSecurityException
from superset.models.sql_lab import Query
from superset.sql_parse import ParsedQuery
from superset.sql.parse import SQLScript
from superset.sqllab.limiting_factor import LimitingFactor
from superset.utils import core as utils, csv
from superset.views.utils import _deserialize_results_payload
@@ -115,10 +115,9 @@ class SqlResultExportCommand(BaseCommand):
limit = None
else:
sql = self._query.executed_sql
limit = ParsedQuery(
sql,
engine=self._query.database.db_engine_spec.engine,
).limit
script = SQLScript(sql, self._query.database.db_engine_spec.engine)
# when a query has multiple statements only the last one returns data
limit = script.statements[-1].get_limit_value()
if limit is not None and self._query.limiting_factor in {
LimitingFactor.QUERY,
LimitingFactor.DROPDOWN,