feat(select): keep options order when in single mode (#19085)

superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx

@@ -116,8 +116,6 @@ const all_columns: typeof sharedControls.groupby = {
         ? [t('must have a value')]
         : [],
   }),
-  sortComparator: (a: { label: string }, b: { label: string }) =>
-    a.label.localeCompare(b.label),
   visibility: isRawMode,
 };
 
@@ -279,8 +277,6 @@ const config: ControlPanelConfig = {
                 choices: datasource?.order_by_choices || [],
               }),
               visibility: isRawMode,
-              sortComparator: (a: { label: string }, b: { label: string }) =>
-                a.label.localeCompare(b.label),
             },
           },
         ],

superset-frontend/plugins/plugin-chart-table/src/utils/isEqualArray.ts

@@ -1,31 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-export default function isEqualArray<T extends unknown[] | undefined | null>(
-  arrA: T,
-  arrB: T,
-) {
-  return (
-    arrA === arrB ||
-    (!arrA && !arrB) ||
-    (arrA &&
-      arrB &&
-      arrA.length === arrB.length &&
-      arrA.every((x, i) => x === arrB[i]))
-  );
-}

superset-frontend/plugins/plugin-chart-table/src/utils/isEqualColumns.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import isEqualArray from './isEqualArray';
+import { isEqualArray } from '@superset-ui/core';
 import { TableChartProps } from '../types';
 
 export default function isEqualColumns(

superset-frontend/plugins/plugin-chart-table/tsconfig.json

@@ -4,16 +4,9 @@
     "outDir": "lib",
     "rootDir": "src"
   },
-  "exclude": [
-    "lib",
-    "test"
-  ],
+  "exclude": ["lib", "test"],
   "extends": "../../tsconfig.json",
-  "include": [
-    "src/**/*",
-    "types/**/*",
-    "../../types/**/*",
-  ],
+  "include": ["src/**/*", "types/**/*", "../../types/**/*"],
   "references": [
     {
       "path": "../../packages/superset-ui-chart-controls"