QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sql-lab] fix react warnings in dev (#1232)

Browse Source 
* rename file to match class

* fix react warnings

* fix proptype typo

* add missing keys
This commit is contained in:
Alanna Scott
2016-10-03 23:58:47 -07:00
committed by GitHub
parent e6e902e8df
commit ae54ac9d58
6 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx
View File

@@ -28,7 +28,7 @@ import shortid from 'shortid';
import SouthPane from './SouthPane';
import Timer from './Timer';
import SqlEditorLeft from './SqlEditorLeft';
import SqlEditorTopToolbar from './SqlEditorTopToolbar';
class SqlEditor extends React.Component {
constructor(props) {
@@ -155,6 +155,7 @@ class SqlEditor extends React.Component {
style={{ width: '100px' }}
onClick={this.runQuery.bind(this, false)}
disabled={!(this.props.queryEditor.dbId)}
key={shortid.generate()}
>
<i className="fa fa-table" /> Run Query
</Button>
@@ -168,6 +169,7 @@ class SqlEditor extends React.Component {
style={{ width: '100px' }}
onClick={this.runQuery.bind(this, true)}
disabled={!(this.props.queryEditor.dbId)}
key={shortid.generate()}
>
<i className="fa fa-table" /> Run Async
</Button>
@@ -250,7 +252,7 @@ class SqlEditor extends React.Component {
<div className="SqlEditor" style={{ minHeight: this.sqlEditorHeight() }}>
<Row>
<Col md={3}>
<SqlEditorLeft queryEditor={this.props.queryEditor} />
<SqlEditorTopToolbar queryEditor={this.props.queryEditor} />
</Col>
<Col md={9}>
<AceEditor