QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-01 05:39:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): recursive parent on dashboard components (#16933)

Browse Source 
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test

(cherry picked from commit a07c9d591b)
This commit is contained in:
Ville Brofeldt
2021-10-01 17:13:38 +02:00
committed by Ville Brofeldt
parent ddc01a9b76
commit b04a9f8ca1
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js
View File

@@ -94,7 +94,11 @@ describe('newEntitiesFromDrop', () => {
expect(result.a.children).toHaveLength(1);
expect(Object.keys(result)).toHaveLength(3);
expect(result[newRowId].type).toBe(ROW_TYPE);
expect(result[newChartId].type).toBe(CHART_TYPE);
const newRow = result[newRowId];
expect(newRow.type).toBe(ROW_TYPE);
expect(newRow.parents).toEqual(['a']);
const newChart = result[newChartId];
expect(newChart.type).toBe(CHART_TYPE);
expect(newChart.parents).toEqual(['a', newRowId]);
});
});