QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle nulls in bar chart series/breakdown (#8724)

Browse Source 
* handle nulls in bar chart series/breakdown

* snake_case

* add tests for null groups in bar charts

* black

* comments will save us
This commit is contained in:
David Aaron Suddjian
2019-12-03 16:11:15 -08:00
committed by Erik Ritter
parent 5e1a6eafe4
commit b0b93768bb
8 changed files with 121 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset/assets/spec/javascripts/utils/common_spec.jsx
View File

@@ -19,6 +19,7 @@
import {
optionFromValue,
prepareCopyToClipboardTabularData,
NULL_STRING,
} from '../../../src/utils/common';
describe('utils/common', () => {
@@ -30,8 +31,8 @@ describe('utils/common', () => {
});
expect(optionFromValue(true)).toEqual({ value: true, label: '<true>' });
expect(optionFromValue(null)).toEqual({
value: '<NULL>',
label: '<NULL>',
value: NULL_STRING,
label: NULL_STRING,
});
expect(optionFromValue('')).toEqual({
value: '',