QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-25 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(explore): Update chart save to use API endpoints (#20498)

Browse Source 
* Update SaveModal to use v1 API instead of POST /explore.

* Refactor SaveModal tests and remove obsolete ones.

* Fix redirect to /explore on save.

* Add toasts (but they don't work).

* Move logic inside try block, clarify unary-plus use.

* Add tests.

* Fix owners bug in updateSlice, enable navigation to dashboard w/o reload.

* Fix toasts.

* Fix translated strings.

* Fix unintended removal from dashboard bug.

* Fix native filters bug.

* Don't refresh Explore page after saving

* Use JSON payload shorthand.

* Prevent current dashboards being overwritten on viz type change.
This commit is contained in:
Cody Leff
2022-07-12 22:36:31 -06:00
committed by GitHub
parent c3ac61271a
commit b1020e3062
9 changed files with 743 additions and 402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.ts
View File

@@ -17,6 +17,11 @@
* under the License.
*/
export interface Location {
search: string;
pathname: string;
}
// mapping { url_param: v1_explore_request_param }
const EXPLORE_URL_SEARCH_PARAMS = {
form_data: {
@@ -70,8 +75,8 @@ const EXPLORE_URL_PATH_PARAMS = {
// search params can be placed in form_data object
// we need to "flatten" the search params to use them with /v1/explore endpoint
const getParsedExploreURLSearchParams = () => {
const urlSearchParams = new URLSearchParams(window.location.search);
const getParsedExploreURLSearchParams = (search: string) => {
const urlSearchParams = new URLSearchParams(search);
return Object.keys(EXPLORE_URL_SEARCH_PARAMS).reduce((acc, currentParam) => {
const paramValue = urlSearchParams.get(currentParam);
if (paramValue === null) {
@@ -96,21 +101,23 @@ const getParsedExploreURLSearchParams = () => {
};
// path params need to be transformed to search params to use them with /v1/explore endpoint
const getParsedExploreURLPathParams = () =>
const getParsedExploreURLPathParams = (pathname: string) =>
Object.keys(EXPLORE_URL_PATH_PARAMS).reduce((acc, currentParam) => {
const re = new RegExp(`/(${currentParam})/(\\w+)`);
const pathGroups = window.location.pathname.match(re);
const pathGroups = pathname.match(re);
if (pathGroups && pathGroups[2]) {
return { ...acc, [EXPLORE_URL_PATH_PARAMS[currentParam]]: pathGroups[2] };
}
return acc;
}, {});
export const getParsedExploreURLParams = () =>
export const getParsedExploreURLParams = (
location: Location = window.location,
) =>
new URLSearchParams(
Object.entries({
...getParsedExploreURLSearchParams(),
...getParsedExploreURLPathParams(),
...getParsedExploreURLSearchParams(location.search),
...getParsedExploreURLPathParams(location.pathname),
})
.map(entry => entry.join('='))
.join('&'),