QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sqllab] optimizing React (#1438)

Browse Source 
* [sqllab] optimizing React

* Addressing comments and making npm run dev faster
This commit is contained in:
Maxime Beauchemin
2016-10-26 17:41:46 -07:00
committed by GitHub
parent 64d196442f
commit b24206387b
20 changed files with 133 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
caravel/assets/javascripts/SqlLab/components/TableElement.jsx
View File

@@ -9,7 +9,6 @@ import ModalTrigger from '../../components/ModalTrigger';
const propTypes = {
table: React.PropTypes.object,
queryEditor: React.PropTypes.object,
actions: React.PropTypes.object,
};
@@ -18,7 +17,7 @@ const defaultProps = {
actions: {},
};
class TableElement extends React.Component {
class TableElement extends React.PureComponent {
popSelectStar() {
const qe = {
@@ -46,7 +45,7 @@ class TableElement extends React.Component {
}
dataPreviewModal() {
const query = {
dbId: this.props.queryEditor.dbId,
dbId: this.props.table.dbId,
sql: this.props.table.selectStar,
tableName: this.props.table.name,
sqlEditorId: null,