QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sql_parse): Ensure table extraction handles Jinja templating (#27470)

Browse Source
This commit is contained in:
John Bodley
2024-03-22 13:39:28 +13:00
committed by GitHub
parent a8c01f4cad
commit b25dd0c055
7 changed files with 141 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset/commands/sql_lab/execute.py
View File

@@ -144,11 +144,13 @@ class ExecuteSqlCommand(BaseCommand):
try:
logger.info("Triggering query_id: %i", query.id)
# Necessary to check access before rendering the Jinjafied query as the
# some Jinja macros execute statements upon rendering.
self._validate_access(query)
self._execution_context.set_query(query)
rendered_query = self._sql_query_render.render(self._execution_context)
validate_rendered_query = copy.copy(query)
validate_rendered_query.sql = rendered_query
self._validate_access(validate_rendered_query)
self._set_query_limit_if_required(rendered_query)
self._query_dao.update(
query, {"limit": self._execution_context.query.limit}