[lint] turn no-undef back on, set browser, cypress, and mocha env's (#5879)

* [lint] turn no-undef back on, set browser, cypress, and mocha env's, and fix issues

* [lint] fix undefined var in TimeTable.jsx

superset/assets/spec/javascripts/dashboard/.eslintrc

@@ -17,7 +17,6 @@
     "no-mixed-operators": 0,
     "no-continue": 2,
     "no-bitwise": 2,
-    "no-undef": 2,
     "no-multi-assign": 2,
     "no-restricted-properties": 2,
     "no-prototype-builtins": 2,

superset/assets/spec/javascripts/dashboard/actions/dashboardLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/CodeModal_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import CodeModal from '../../../../src/dashboard/components/CodeModal';

superset/assets/spec/javascripts/dashboard/components/CssEditor_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import CssEditor from '../../../../src/dashboard/components/CssEditor';

superset/assets/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { shallow, mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ParentSize from '@vx/responsive/build/components/ParentSize';

superset/assets/spec/javascripts/dashboard/components/DashboardGrid_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/Dashboard_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/HeaderActionsDropdown_spec.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import { shallow } from 'enzyme';
 import { DropdownButton, MenuItem } from 'react-bootstrap';

superset/assets/spec/javascripts/dashboard/components/Header_spec.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import { shallow } from 'enzyme';
 import Header from '../../../../src/dashboard/components/Header';

superset/assets/spec/javascripts/dashboard/components/MissingChart_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import Loading from '../../../../src/components/Loading';

superset/assets/spec/javascripts/dashboard/components/RefreshIntervalModal_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import RefreshIntervalModal from '../../../../src/dashboard/components/RefreshIntervalModal';

superset/assets/spec/javascripts/dashboard/components/SliceAdder_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it, beforeEach, afterEach } from 'mocha';
 import sinon from 'sinon';
 import { expect } from 'chai';
 

superset/assets/spec/javascripts/dashboard/components/dnd/DragDroppable_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow, mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/ChartHolder_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Column_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Divider_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Header_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Markdown_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 import AceEditor from 'react-ace';

superset/assets/spec/javascripts/dashboard/components/gridComponents/Row_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Tab_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 import { Tabs as BootstrapTabs, Tab as BootstrapTab } from 'react-bootstrap';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/DraggableNewComponent_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DragDroppable from '../../../../../../src/dashboard/components/dnd/DragDroppable';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewColumn_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewDivider_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewHeader_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewRow_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewTabs_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/menu/HoverMenu_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import HoverMenu from '../../../../../src/dashboard/components/menu/HoverMenu';

superset/assets/spec/javascripts/dashboard/components/menu/WithPopoverMenu_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import WithPopoverMenu from '../../../../../src/dashboard/components/menu/WithPopoverMenu';

superset/assets/spec/javascripts/dashboard/components/resizable/ResizableContainer_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import Resizable from 're-resizable';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ResizableContainer from '../../../../../src/dashboard/components/resizable/ResizableContainer';

superset/assets/spec/javascripts/dashboard/components/resizable/ResizableHandle_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ResizableHandle from '../../../../../src/dashboard/components/resizable/ResizableHandle';

superset/assets/spec/javascripts/dashboard/reducers/dashboardLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import layoutReducer from '../../../../src/dashboard/reducers/dashboardLayout';

superset/assets/spec/javascripts/dashboard/reducers/dashboardState_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import {

superset/assets/spec/javascripts/dashboard/reducers/sliceEntities_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import {

superset/assets/spec/javascripts/dashboard/util/componentIsResizable_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import componentIsResizable from '../../../../src/dashboard/util/componentIsResizable';

superset/assets/spec/javascripts/dashboard/util/dnd-reorder_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import reorderItem from '../../../../src/dashboard/util/dnd-reorder';

superset/assets/spec/javascripts/dashboard/util/dropOverflowsParent_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import dropOverflowsParent from '../../../../src/dashboard/util/dropOverflowsParent';

superset/assets/spec/javascripts/dashboard/util/findFirstParentContainer_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import findFirstParentContainerId from '../../../../src/dashboard/util/findFirstParentContainer';

superset/assets/spec/javascripts/dashboard/util/findParentId_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import findParentId from '../../../../src/dashboard/util/findParentId';

superset/assets/spec/javascripts/dashboard/util/getChartIdsFromLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getChartIdsFromLayout from '../../../../src/dashboard/util/getChartIdsFromLayout';

superset/assets/spec/javascripts/dashboard/util/getDashboardUrl_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDashboardUrl from '../../../../src/dashboard/util/getDashboardUrl';

superset/assets/spec/javascripts/dashboard/util/getDetailedComponentWidth_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDetailedComponentWidth from '../../../../src/dashboard/util/getDetailedComponentWidth';

superset/assets/spec/javascripts/dashboard/util/getDropPosition_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDropPosition, {

superset/assets/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getFormDataWithExtraFilters from '../../../../src/dashboard/util/charts/getFormDataWithExtraFilters';

superset/assets/spec/javascripts/dashboard/util/isValidChild_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import isValidChild from '../../../../src/dashboard/util/isValidChild';

superset/assets/spec/javascripts/dashboard/util/newComponentFactory_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';

superset/assets/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import newEntitiesFromDrop from '../../../../src/dashboard/util/newEntitiesFromDrop';