From b4c7459890b559fe41d43663bf78be1fbfa85c7e Mon Sep 17 00:00:00 2001 From: Joe Li Date: Tue, 19 May 2026 15:09:41 -0700 Subject: [PATCH] chore: update comment since it's not really verbatim --- tests/unit_tests/sql/parse_tests.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/unit_tests/sql/parse_tests.py b/tests/unit_tests/sql/parse_tests.py index 61dca68e997..09313a1f77e 100644 --- a/tests/unit_tests/sql/parse_tests.py +++ b/tests/unit_tests/sql/parse_tests.py @@ -1195,12 +1195,13 @@ def test_with_clause_containing_union_is_not_mutating(engine: str) -> None: def test_with_clause_containing_union_all_is_not_mutating_oracle() -> None: """ - Companion to test_with_clause_containing_union_is_not_mutating: the - original bug report (#25659) used the exact Oracle-flavored shape below - (``SYSDATE FROM DUAL`` is the Oracle no-op for "now"). Pinning the - verbatim repro guards against a future dialect-specific regression that - a generic ``SELECT 1`` test might miss. - """ + Companion to test_with_clause_containing_union_is_not_mutating: exercises + UNION ALL (a sibling of UNION whose per-dialect sqlglot AST shape can + diverge) on the Oracle-flavored ``SYSDATE FROM DUAL`` form from #25659. + UNION is covered by the parametrized test above; this guards against a + UNION-ALL-specific or Oracle-shape-specific regression that a generic + ``SELECT 1 UNION SELECT 2`` test might miss. +""" sql = """ WITH SET1 AS (SELECT SYSDATE FROM DUAL UNION ALL SELECT SYSDATE FROM DUAL), SET2 AS (SELECT * FROM SET1)