QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-14 13:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sqllab] bugfix SouthPane doesn't update as expected (#1699)

Browse Source 
* [sqllab] bugfix SouthPane doesn't update as expected

* Linting
This commit is contained in:
Maxime Beauchemin
2016-11-28 16:24:02 -08:00
committed by GitHub
parent 84e8f741ae
commit b7019ad4f3
2 changed files with 21 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/assets/javascripts/SqlLab/components/SouthPane.jsx
View File

@@ -5,7 +5,6 @@ import { connect } from 'react-redux';
import { bindActionCreators } from 'redux';
import * as Actions from '../actions';
import React from 'react';
import { areArraysShallowEqual } from '../../reduxUtils';
import shortid from 'shortid';
@@ -28,11 +27,6 @@ class SouthPane extends React.PureComponent {
switchTab(id) {
this.props.actions.setActiveSouthPaneTab(id);
}
shouldComponentUpdate(nextProps) {
return !areArraysShallowEqual(this.props.editorQueries, nextProps.editorQueries)
|| !areArraysShallowEqual(this.props.dataPreviewQueries, nextProps.dataPreviewQueries)
|| this.props.activeSouthPaneTab !== nextProps.activeSouthPaneTab;
}
render() {
let latestQuery;
const props = this.props;