QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-24 02:25:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): dnd error when dragging metric if multi: false (#16088)

Browse Source 
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
This commit is contained in:
Kamil Gabryjelski
2021-08-09 18:15:50 +02:00
committed by GitHub
parent 578a9e9d53
commit b7cc89c6d4
5 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
View File

@@ -245,7 +245,10 @@ export const DndMetricSelect = (props: any) => {
[props.savedMetrics, props.value],
);
const handleDropLabel = useCallback(() => onChange(value), [onChange, value]);
const handleDropLabel = useCallback(
() => onChange(multi ? value : value[0]),
[multi, onChange, value],
);
const valueRenderer = useCallback(
(option: Metric | AdhocMetric | string, index: number) => (
@@ -262,12 +265,14 @@ export const DndMetricSelect = (props: any) => {
onMoveLabel={moveLabel}
onDropLabel={handleDropLabel}
type={`${DndItemType.AdhocMetricOption}_${props.name}_${props.label}`}
multi={multi}
/>
),
[
getSavedMetricOptionsForMetric,
handleDropLabel,
moveLabel,
multi,
onMetricEdit,
onRemoveMetric,
props.columns,