QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mssql): support cte in virtual tables (#18567)

Browse Source 
* Fix for handling regular CTE queries with MSSQL,#8074

* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine

* Fix for handling regular CTE queries with MSSQL,#8074

* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine

* Unit test added for the db engine CTE SQL parsing.

Unit test added for the db engine CTE SQL parsing.  Removed additional spaces from the CTE parsing SQL generation.

* implement in sqla model

* lint + cleanup

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
This commit is contained in:
Sujith Kumar S
2022-02-10 13:58:05 +05:30
committed by GitHub
parent 00eb6b1f57
commit b8aef10098
6 changed files with 165 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration_tests/core_tests.py
View File

@@ -984,7 +984,7 @@ class TestCore(SupersetTestCase):
sql=commented_query,
database=get_example_database(),
)
rendered_query = str(table.get_from_clause())
rendered_query = str(table.get_from_clause()[0])
self.assertEqual(clean_query, rendered_query)
def test_slice_payload_no_datasource(self):