QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): use server-side lastModifiedTime for co-edit check (#11614)

Browse Source 
* fix: [dashboard][co-edit] Round client-side lastModifiedTime

* another try: server-side returns last_updated_time in save_dash response
This commit is contained in:
Grace Guo
2020-11-09 13:30:40 -08:00
committed by GitHub
parent dda95ed250
commit b9284d3a3c
5 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/spec/javascripts/dashboard/reducers/dashboardState_spec.js
View File

@@ -131,19 +131,22 @@ describe('dashboardState reducer', () => {
expect(result.updatedColorScheme).toBe(false);
});
it('should set lastModifiedTime on save', () => {
const lastModifiedTime = new Date().getTime() / 1000;
it('should reset lastModifiedTime on save', () => {
const initTime = new Date().getTime() / 1000;
dashboardStateReducer(
{
lastModifiedTime,
lastModifiedTime: initTime,
},
{},
);
const lastModifiedTime = Math.round(new Date().getTime() / 1000);
expect(
dashboardStateReducer({ hasUnsavedChanges: true }, { type: ON_SAVE })
.lastModifiedTime,
).toBeGreaterThanOrEqual(lastModifiedTime);
dashboardStateReducer(
{ hasUnsavedChanges: true },
{ type: ON_SAVE, lastModifiedTime },
).lastModifiedTime,
).toBeGreaterThanOrEqual(initTime);
});
it('should clear the focused filter field', () => {