QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: DB parameter validation (#14636)

Browse Source
This commit is contained in:
Beto Dealmeida
2021-05-14 14:07:34 -07:00
committed by GitHub
parent 6d9d362ca8
commit ba5d66cb0a
3 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/databases/api_tests.py
View File

@@ -19,6 +19,7 @@
"""Unit tests for Superset"""
import dataclasses
import json
from collections import defaultdict
from io import BytesIO
from unittest import mock
from zipfile import is_zipfile, ZipFile
@@ -1369,15 +1370,18 @@ class TestDatabaseApi(SupersetTestCase):
url = "api/v1/database/validate_parameters"
payload = {
"engine": "postgresql",
"parameters": {
"parameters": defaultdict(dict),
}
payload["parameters"].update(
{
"host": "",
"port": 5432,
"username": "",
"password": "",
"database": "",
"query": {},
},
}
}
)
rv = self.client.post(url, json=payload)
response = json.loads(rv.data.decode("utf-8"))
@@ -1409,15 +1413,18 @@ class TestDatabaseApi(SupersetTestCase):
url = "api/v1/database/validate_parameters"
payload = {
"engine": "postgresql",
"parameters": {
"parameters": defaultdict(dict),
}
payload["parameters"].update(
{
"host": "localhost",
"port": 5432,
"username": "",
"password": "",
"database": "",
"query": {},
},
}
}
)
rv = self.client.post(url, json=payload)
response = json.loads(rv.data.decode("utf-8"))