QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump superset-ui-connection to 0.12.22 (#9602)

Browse Source
This commit is contained in:
Erik Ritter
2020-04-21 11:36:01 -07:00
committed by GitHub
parent 2b957a2c1e
commit ba691d3a27
5 changed files with 78 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/spec/javascripts/chart/chartActions_spec.js
View File

@@ -141,7 +141,7 @@ describe('chart actions', () => {
{ overwriteRoutes: true },
);
const timeoutInSec = 1 / 1000;
const timeoutInSec = 100; // Set to a time that is longer than the time this will take to fail
const actionThunk = actions.postChartFormData({}, false, timeoutInSec);
return actionThunk(dispatch).then(() => {

22
superset-frontend/spec/javascripts/components/AsyncSelect_spec.jsx
View File

@@ -113,7 +113,7 @@ describe('AsyncSelect', () => {
});
});
it('should call onAsyncError if there is an error fetching options', done => {
it('should call onAsyncError if there is an error fetching options', () => {
expect.assertions(3);
const errorEndpoint = 'async/error/';
@@ -121,7 +121,7 @@ describe('AsyncSelect', () => {
fetchMock.get(errorGlob, { throws: 'error' });
const onAsyncError = jest.fn();
shallow(
const wrapper = shallow(
<AsyncSelect
{...mockedProps}
dataEndpoint={errorEndpoint}
@@ -129,12 +129,18 @@ describe('AsyncSelect', () => {
/>,
);
setTimeout(() => {
expect(fetchMock.calls(errorGlob)).toHaveLength(1);
expect(onAsyncError.mock.calls).toHaveLength(1);
expect(onAsyncError).toBeCalledWith('error');
done();
});
return wrapper
.instance()
.fetchOptions()
.then(() => {
// Fails then retries thrice whenever fetching options, which happens twice:
// once on component mount and once when calling `fetchOptions` again
expect(fetchMock.calls(errorGlob)).toHaveLength(8);
expect(onAsyncError.mock.calls).toHaveLength(2);
expect(onAsyncError).toBeCalledWith('error');
return Promise.resolve();
});
});
});
});

3
superset-frontend/spec/javascripts/sqllab/ShareSqlLabQuery_spec.jsx
View File

@@ -132,7 +132,8 @@ describe('ShareSqlLabQuery via /kv/store', () => {
.instance()
.getCopyUrl()
.then(() => {
expect(fetchMock.calls(storeQueryUrl)).toHaveLength(1);
// Fails then retries thrice
expect(fetchMock.calls(storeQueryUrl)).toHaveLength(4);
expect(addDangerToastSpy.mock.calls).toHaveLength(1);
expect(addDangerToastSpy.mock.calls[0][0]).toBe(error);