From bae2c90bae5bd944f5186390a5100384e9304c63 Mon Sep 17 00:00:00 2001 From: Akshat Sinha <113134119+akshatsinha0@users.noreply.github.com> Date: Mon, 3 Nov 2025 22:39:58 +0530 Subject: [PATCH] docs: correct spelling typos in project codebase (#35935) --- UPDATING.md | 2 +- superset-frontend/src/components/GridTable/Header.test.tsx | 2 +- superset-frontend/src/explore/reducers/exploreReducer.js | 2 +- superset/commands/database/test_connection.py | 2 +- superset/reports/notifications/email.py | 4 ++-- superset/utils/log.py | 2 +- tests/unit_tests/utils/screenshot_test.py | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index f34c46debf0..cc812016808 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -41,7 +41,7 @@ Note: Pillow is now a required dependency (previously optional) to support image - [33116](https://github.com/apache/superset/pull/33116) In Echarts Series charts (e.g. Line, Area, Bar, etc.) charts, the `x_axis_sort_series` and `x_axis_sort_series_ascending` form data items have been renamed with `x_axis_sort` and `x_axis_sort_asc`. There's a migration added that can potentially affect a significant number of existing charts. - [32317](https://github.com/apache/superset/pull/32317) The horizontal filter bar feature is now out of testing/beta development and its feature flag `HORIZONTAL_FILTER_BAR` has been removed. -- [31590](https://github.com/apache/superset/pull/31590) Marks the begining of intricate work around supporting dynamic Theming, and breaks support for [THEME_OVERRIDES](https://github.com/apache/superset/blob/732de4ac7fae88e29b7f123b6cbb2d7cd411b0e4/superset/config.py#L671) in favor of a new theming system based on AntD V5. Likely this will be in disrepair until settling over the 5.x lifecycle. +- [31590](https://github.com/apache/superset/pull/31590) Marks the beginning of intricate work around supporting dynamic Theming, and breaks support for [THEME_OVERRIDES](https://github.com/apache/superset/blob/732de4ac7fae88e29b7f123b6cbb2d7cd411b0e4/superset/config.py#L671) in favor of a new theming system based on AntD V5. Likely this will be in disrepair until settling over the 5.x lifecycle. - [32432](https://github.com/apache/superset/pull/31260) Moves the List Roles FAB view to the frontend and requires `FAB_ADD_SECURITY_API` to be enabled in the configuration and `superset init` to be executed. - [34319](https://github.com/apache/superset/pull/34319) Drill to Detail and Drill By is now supported in Embedded mode, and also with the `DASHBOARD_RBAC` FF. If you don't want to expose these features in Embedded / `DASHBOARD_RBAC`, make sure the roles used for Embedded / `DASHBOARD_RBAC`don't have the required permissions to perform D2D actions. diff --git a/superset-frontend/src/components/GridTable/Header.test.tsx b/superset-frontend/src/components/GridTable/Header.test.tsx index 9976df6c814..cc747ee8762 100644 --- a/superset-frontend/src/components/GridTable/Header.test.tsx +++ b/superset-frontend/src/components/GridTable/Header.test.tsx @@ -81,7 +81,7 @@ test('sorts by clicking a column header', () => { expect(queryByTestId('mock-sort-desc')).not.toBeInTheDocument(); }); -test('synchronizes the current sort when sortChanged event occured', async () => { +test('synchronizes the current sort when sortChanged event occurred', async () => { const { findByTestId } = render(
); act(() => { mockedProps.api.dispatchEvent(new Event('sortChanged')); diff --git a/superset-frontend/src/explore/reducers/exploreReducer.js b/superset-frontend/src/explore/reducers/exploreReducer.js index 156459353e8..df728ee482b 100644 --- a/superset-frontend/src/explore/reducers/exploreReducer.js +++ b/superset-frontend/src/explore/reducers/exploreReducer.js @@ -240,7 +240,7 @@ export default function exploreReducer(state = {}, action) { }; return { - // Re run validation for dependant controls + // Re run validation for dependent controls controlState: getControlStateFromControlConfig( controlState, overWrittenState, diff --git a/superset/commands/database/test_connection.py b/superset/commands/database/test_connection.py index 1bbb0013a47..68f0cbccc9d 100644 --- a/superset/commands/database/test_connection.py +++ b/superset/commands/database/test_connection.py @@ -163,7 +163,7 @@ class TestConnectionDatabaseCommand(BaseCommand): if not alive: raise DBAPIError(ex_str or None, None, None) - # Log succesful connection test with engine + # Log successful connection test with engine event_logger.log_with_context( action=get_log_connection_action("test_connection_success", ssh_tunnel), engine=database.db_engine_spec.__name__, diff --git a/superset/reports/notifications/email.py b/superset/reports/notifications/email.py index 052ca610117..4f3e24d9dcc 100644 --- a/superset/reports/notifications/email.py +++ b/superset/reports/notifications/email.py @@ -221,11 +221,11 @@ class EmailNotification(BaseNotification): # pylint: disable=too-few-public-met return json.loads(self._recipient.recipient_config_json)["target"] def _get_cc(self) -> str: - # To accomadate backward compatability + # To accommodate backward compatibility return json.loads(self._recipient.recipient_config_json).get("ccTarget", "") def _get_bcc(self) -> str: - # To accomadate backward compatability + # To accommodate backward compatibility return json.loads(self._recipient.recipient_config_json).get("bccTarget", "") @statsd_gauge("reports.email.send") diff --git a/superset/utils/log.py b/superset/utils/log.py index 3a4a5ebb368..8e31b86b269 100644 --- a/superset/utils/log.py +++ b/superset/utils/log.py @@ -343,7 +343,7 @@ def get_event_logger_from_cfg_value(cfg_value: Any) -> AbstractEventLogger: textwrap.dedent( """ In superset private config, EVENT_LOGGER has been assigned a class - object. In order to accomodate pre-configured instances without a + object. In order to accommodate pre-configured instances without a default constructor, assignment of a class is deprecated and may no longer work at some point in the future. Please assign an object instance of a type that implements diff --git a/tests/unit_tests/utils/screenshot_test.py b/tests/unit_tests/utils/screenshot_test.py index db5036cd7e9..cb684b827f9 100644 --- a/tests/unit_tests/utils/screenshot_test.py +++ b/tests/unit_tests/utils/screenshot_test.py @@ -91,7 +91,7 @@ def test_get_cache_key(screenshot_obj): def test_get_from_cache_key(mocker: MockerFixture, screenshot_obj): """get_from_cache_key should always return a ScreenshotCachePayload Object""" - # backwards compatability test for retrieving plain bytes + # backwards compatibility test for retrieving plain bytes fake_bytes = b"fake_screenshot_data" BaseScreenshot.cache = MockCache() BaseScreenshot.cache.set("key", fake_bytes)