diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/components/ControlHeader/controlHeader.tsx b/superset-frontend/plugins/plugin-chart-handlebars/src/components/ControlHeader/controlHeader.tsx index 2dac822f8f2..460b56f1969 100644 --- a/superset-frontend/plugins/plugin-chart-handlebars/src/components/ControlHeader/controlHeader.tsx +++ b/superset-frontend/plugins/plugin-chart-handlebars/src/components/ControlHeader/controlHeader.tsx @@ -26,8 +26,6 @@ export const ControlHeader = ({ children, }: ControlHeaderProps): JSX.Element => (
-
- {children} -
+
{children}
); diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/style.tsx b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/style.tsx index d3776e77827..f89a1a6679e 100644 --- a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/style.tsx +++ b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/style.tsx @@ -20,8 +20,9 @@ import { ControlSetItem, CustomControlConfig, sharedControls, + InfoTooltipWithTrigger, } from '@superset-ui/chart-controls'; -import { t } from '@superset-ui/core'; +import { t, useTheme } from '@superset-ui/core'; import React from 'react'; import { CodeEditor } from '../../components/CodeEditor/CodeEditor'; import { ControlHeader } from '../../components/ControlHeader/controlHeader'; @@ -32,17 +33,32 @@ interface StyleCustomControlProps { } const StyleControl = (props: CustomControlConfig) => { - const val = String( - props?.value ? props?.value : props?.default ? props?.default : '', - ); + const theme = useTheme(); + + const defaultValue = props?.value + ? undefined + : `/* + .data-list { + background-color: yellow; + } +*/`; return (
- {props.label} + +
+ {props.label} + +
+
{ debounceFunc(props.onChange, source || ''); }} @@ -58,11 +74,6 @@ export const styleControlSetItem: ControlSetItem = { type: StyleControl, label: t('CSS Styles'), description: t('CSS applied to the chart'), - default: `/* -.data-list { - background-color: yellow; -} -*/`, isInt: false, renderTrigger: true,