QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-22 16:25:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bigquery): address deferred review follow-ups

Browse Source 
Cache persistence: persist bq_memory_limited flag in QueryCacheManager
so truncation warnings survive cache hits. The flag is now saved into
the cache value dict in set_query_result (reading from g and resetting
it there), and restored from cache in get(). get_df_payload now reads
cache.bq_memory_limited instead of g, removing the need for g entirely
in query_context_processor.py.

Frontend test: add two tests to chartActions.test.ts verifying that
addWarningToast is dispatched (with noDuplicate: true) when a query
response carries a warning field, and not dispatched when it doesn't.

Updated existing test_query_context_processor tests to set the flag on
mock_cache directly rather than patching g.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Claude Code
2026-04-07 13:43:11 -07:00
parent 1894b77b44
commit bbbd1490ef
4 changed files with 79 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unit_tests/common/test_query_context_processor.py
View File

@@ -1426,17 +1426,14 @@ def test_get_df_payload_bq_memory_limited_warning():
mock_cache.sql_rowcount = 3
mock_cache.cache_dttm = "2024-01-01T00:00:00"
mock_cache.queried_dttm = "2024-01-01T00:00:00"
mock_cache.bq_memory_limited = True
mock_cache.bq_memory_limited_row_count = 5000
mock_cache_manager.get.return_value = mock_cache
with patch.object(query_obj, "validate", return_value=None):
with patch.object(processor, "query_cache_key", return_value="key"):
with patch.object(processor, "get_cache_timeout", return_value=3600):
# Simulate BigQuery memory-limited flag being set on Flask g
with patch("superset.common.query_context_processor.g") as mock_g:
mock_g.bq_memory_limited = True
mock_g.bq_memory_limited_row_count = 5000
result = processor.get_df_payload(query_obj, force_cached=False)
result = processor.get_df_payload(query_obj, force_cached=False)
assert result["warning"] is not None
assert "Chart 42" in result["warning"]
@@ -1489,15 +1486,12 @@ def test_get_df_payload_no_warning_when_not_memory_limited():
mock_cache.sql_rowcount = 2
mock_cache.cache_dttm = "2024-01-01T00:00:00"
mock_cache.queried_dttm = "2024-01-01T00:00:00"
mock_cache.bq_memory_limited = False
mock_cache_manager.get.return_value = mock_cache
with patch.object(query_obj, "validate", return_value=None):
with patch.object(processor, "query_cache_key", return_value="key"):
with patch.object(processor, "get_cache_timeout", return_value=3600):
# g.bq_memory_limited is not set (default)
with patch("superset.common.query_context_processor.g") as mock_g:
mock_g.bq_memory_limited = False
result = processor.get_df_payload(query_obj, force_cached=False)
result = processor.get_df_payload(query_obj, force_cached=False)
assert result["warning"] is None