chore(tests): Remove unnecessary/problematic app contexts (#28159)

This commit is contained in:
John Bodley
2024-04-24 13:46:35 -07:00
committed by GitHub
parent a9075fdb1f
commit bc65c245fe
24 changed files with 880 additions and 980 deletions

View File

@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
import pytest
from flask.ctx import AppContext
from flask_appbuilder.security.sqla.models import Role, User
from superset import db, security_manager
@@ -23,27 +24,24 @@ from tests.integration_tests.test_app import app
@pytest.fixture()
def create_gamma_sqllab_no_data():
with app.app_context():
gamma_role = db.session.query(Role).filter(Role.name == "Gamma").one_or_none()
sqllab_role = (
db.session.query(Role).filter(Role.name == "sql_lab").one_or_none()
)
def create_gamma_sqllab_no_data(app_context: AppContext):
gamma_role = db.session.query(Role).filter(Role.name == "Gamma").one_or_none()
sqllab_role = db.session.query(Role).filter(Role.name == "sql_lab").one_or_none()
security_manager.add_user(
GAMMA_SQLLAB_NO_DATA_USERNAME,
"gamma_sqllab_no_data",
"gamma_sqllab_no_data",
"gamma_sqllab_no_data@apache.org",
[gamma_role, sqllab_role],
password="general",
)
security_manager.add_user(
GAMMA_SQLLAB_NO_DATA_USERNAME,
"gamma_sqllab_no_data",
"gamma_sqllab_no_data",
"gamma_sqllab_no_data@apache.org",
[gamma_role, sqllab_role],
password="general",
)
yield
user = (
db.session.query(User)
.filter(User.username == GAMMA_SQLLAB_NO_DATA_USERNAME)
.one_or_none()
)
db.session.delete(user)
db.session.commit()
yield
user = (
db.session.query(User)
.filter(User.username == GAMMA_SQLLAB_NO_DATA_USERNAME)
.one_or_none()
)
db.session.delete(user)
db.session.commit()