mirror of
https://github.com/apache/superset.git
synced 2026-08-04 21:12:44 +00:00
feat(build): complete migration to Oxfmt for remaining sub-projects
This commit is contained in:
@@ -353,8 +353,8 @@ mypy superset
|
||||
|
||||
We use:
|
||||
|
||||
- **ESLint** for linting
|
||||
- **Prettier** for formatting
|
||||
- **Oxlint** for linting
|
||||
- **Oxfmt** for formatting
|
||||
- **TypeScript** strict mode
|
||||
|
||||
TypeScript is fully supported and is the recommended language for writing all new frontend
|
||||
|
||||
@@ -384,8 +384,8 @@ npm run check:custom-rules
|
||||
# Run tsc (typescript) checks
|
||||
npm run type
|
||||
|
||||
# Format with Prettier
|
||||
npm run prettier
|
||||
# Format with Oxfmt
|
||||
npm run format
|
||||
```
|
||||
|
||||
#### Architecture
|
||||
|
||||
@@ -43,7 +43,7 @@ This is a list of statements that describe how we do frontend development in Sup
|
||||
- We organize our repo so similar files live near each other, and tests are co-located with the files they test.
|
||||
- See: [SIP-61](https://github.com/apache/superset/issues/12098)
|
||||
- We prefer small, easily testable files and components.
|
||||
- We use OXC (oxlint) and Prettier to automatically fix lint errors and format the code.
|
||||
- We use OXC tooling, namely `oxlint` and `oxfmt`, to automatically fix lint errors and format the code.
|
||||
- We do not debate code formatting style in PRs, instead relying on automated tooling to enforce it.
|
||||
- If there's not a linting rule, we don't have a rule!
|
||||
- See: [Linting How-Tos](../contributing/howtos.md#typescript--javascript)
|
||||
|
||||
@@ -33,7 +33,7 @@ Understanding Superset's continuous integration and deployment pipelines.
|
||||
- GitHub Actions workflows
|
||||
- Pre-commit hooks configuration
|
||||
- Automated testing pipelines
|
||||
- Code quality checks (ESLint, Prettier, Black, MyPy)
|
||||
- Code quality checks (Oxlint, Oxfmt, Black, MyPy)
|
||||
- Security scanning (Dependabot, CodeQL)
|
||||
- Docker image building and publishing
|
||||
- Release automation
|
||||
|
||||
Reference in New Issue
Block a user