QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(query): order by adhoc metrics should trigger group by (#13434)

Browse Source 
* fix(query): properly select adhoc metrics in orderby

* Throw error when sql is empty

* Allow `metrics` to be None

* Always use alias in orderby for metrics

* Bump table chart version and migrate histogram to typescript

* Fix Histogram without groupby

* Fix Presto birth names test

* Raw records mode should not aggregate
This commit is contained in:
Jesse Yang
2021-03-16 21:00:03 -07:00
committed by GitHub
parent 72d19b6b35
commit bd1d6acb0c
22 changed files with 8896 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/utils/core.py
View File

@@ -1243,7 +1243,7 @@ def backend() -> str:
def is_adhoc_metric(metric: Metric) -> bool:
return isinstance(metric, dict)
return isinstance(metric, dict) and "expressionType" in metric
def get_metric_name(metric: Metric) -> str: