QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(pylint): Reenable raise-missing-from check (#16266)

Browse Source 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2021-08-16 15:26:10 -07:00
committed by GitHub
parent 36bc7b0b80
commit be7065faf8
80 changed files with 216 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/annotation_layers/annotations/commands/bulk_delete.py
View File

@@ -44,7 +44,7 @@ class BulkDeleteAnnotationCommand(BaseCommand):
return None
except DAODeleteFailedError as ex:
logger.exception(ex.exception)
raise AnnotationBulkDeleteFailedError()
raise AnnotationBulkDeleteFailedError() from ex
def validate(self) -> None:
# Validate/populate model exists

2
superset/annotation_layers/annotations/commands/create.py
View File

@@ -48,7 +48,7 @@ class CreateAnnotationCommand(BaseCommand):
annotation = AnnotationDAO.create(self._properties)
except DAOCreateFailedError as ex:
logger.exception(ex.exception)
raise AnnotationCreateFailedError()
raise AnnotationCreateFailedError() from ex
return annotation
def validate(self) -> None:

2
superset/annotation_layers/annotations/commands/delete.py
View File

@@ -44,7 +44,7 @@ class DeleteAnnotationCommand(BaseCommand):
annotation = AnnotationDAO.delete(self._model)
except DAODeleteFailedError as ex:
logger.exception(ex.exception)
raise AnnotationDeleteFailedError()
raise AnnotationDeleteFailedError() from ex
return annotation
def validate(self) -> None:

2
superset/annotation_layers/annotations/commands/update.py
View File

@@ -52,7 +52,7 @@ class UpdateAnnotationCommand(BaseCommand):
annotation = AnnotationDAO.update(self._model, self._properties)
except DAOUpdateFailedError as ex:
logger.exception(ex.exception)
raise AnnotationUpdateFailedError()
raise AnnotationUpdateFailedError() from ex
return annotation
def validate(self) -> None:

4
superset/annotation_layers/annotations/dao.py
View File

@@ -39,10 +39,10 @@ class AnnotationDAO(BaseDAO):
)
if commit:
db.session.commit()
except SQLAlchemyError:
except SQLAlchemyError as ex:
if commit:
db.session.rollback()
raise DAODeleteFailedError()
raise DAODeleteFailedError() from ex
@staticmethod
def validate_update_uniqueness(

4
superset/annotation_layers/annotations/schemas.py
View File

@@ -51,8 +51,8 @@ annotation_json_metadata = "JSON metadata"
def validate_json(value: Union[bytes, bytearray, str]) -> None:
try:
utils.validate_json(value)
except SupersetException:
raise ValidationError("JSON not valid")
except SupersetException as ex:
raise ValidationError("JSON not valid") from ex
class AnnotationPostSchema(Schema):