chore: Remove CROSS_REFERENCES feature flag (#21815)

superset-frontend/src/explore/components/ExploreChartHeader/index.jsx

@@ -24,8 +24,6 @@ import { Tooltip } from 'src/components/Tooltip';
 import {
   CategoricalColorNamespace,
   css,
-  FeatureFlag,
-  isFeatureEnabled,
   logging,
   SupersetClient,
   t,
@@ -166,8 +164,7 @@ export const ExploreChartHeader = ({
           ? t('Added to %s dashboard(s)', metadata.dashboards.length)
           : t('Not added to any dashboard'),
       description:
-        metadata.dashboards.length > 0 &&
-        isFeatureEnabled(FeatureFlag.CROSS_REFERENCES)
+        metadata.dashboards.length > 0
           ? t(
               'You can preview the list of dashboards on the chart settings dropdown.',
             )

superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/DashboardsSubMenu.tsx

@@ -63,7 +63,7 @@ const DashboardsSubMenu = ({
             margin: ${theme.gridUnit * 2}px ${theme.gridUnit * 3}px;
           `}
           value={dashboardSearch}
-          onChange={e => setDashboardSearch(e.currentTarget.value?.trim())}
+          onChange={e => setDashboardSearch(e.currentTarget.value)}
         />
       )}
       <div

superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx

@@ -255,17 +255,15 @@ export const useExploreAdditionalActionsMenu = (
               {t('Edit chart properties')}
             </Menu.Item>
           )}
-          {isFeatureEnabled(FeatureFlag.CROSS_REFERENCES) && (
-            <Menu.SubMenu
-              title={t('Dashboards added to')}
-              key={MENU_KEYS.DASHBOARDS_ADDED_TO}
-            >
-              <DashboardsSubMenu
-                chartId={slice?.slice_id}
-                dashboards={dashboards}
-              />
-            </Menu.SubMenu>
-          )}
+          <Menu.SubMenu
+            title={t('Dashboards added to')}
+            key={MENU_KEYS.DASHBOARDS_ADDED_TO}
+          >
+            <DashboardsSubMenu
+              chartId={slice?.slice_id}
+              dashboards={dashboards}
+            />
+          </Menu.SubMenu>
           <Menu.Divider />
         </>
         <Menu.SubMenu title={t('Download')} key={MENU_KEYS.DOWNLOAD_SUBMENU}>