refactor(standardized form data): refine interface and improve code smells (#20518)

This commit is contained in:
Yongjie Zhao
2022-06-28 21:09:42 +08:00
committed by GitHub
parent 23e62d3782
commit c348a095b9
34 changed files with 580 additions and 224 deletions

View File

@@ -22,6 +22,7 @@ import {
D3_FORMAT_DOCS,
D3_TIME_FORMAT_OPTIONS,
formatSelectOptions,
getStandardizedControls,
sections,
} from '@superset-ui/chart-controls';
import React from 'react';
@@ -270,13 +271,9 @@ const config: ControlPanelConfig = {
label: t('Number format'),
},
},
denormalizeFormData: formData => ({
formDataOverrides: formData => ({
...formData,
metric: formData.standardizedFormData.standardizedState.metrics[0],
}),
updateStandardizedState: (prevState, currState) => ({
...currState,
metrics: [currState.metrics[0], ...prevState.metrics.slice(1)],
metric: getStandardizedControls().shiftMetric(),
}),
};