QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(standardized form data): refine interface and improve code smells (#20518)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-06-28 21:09:42 +08:00
committed by GitHub
parent 23e62d3782
commit c348a095b9
34 changed files with 580 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
View File

@@ -25,6 +25,7 @@ import {
sections,
emitFilterControl,
ControlPanelConfig,
getStandardizedControls,
} from '@superset-ui/chart-controls';
const config: ControlPanelConfig = {
@@ -136,14 +137,18 @@ const config: ControlPanelConfig = {
),
},
},
denormalizeFormData: formData => {
const groupby =
formData.standardizedFormData.standardizedState.columns.filter(
col => !ensureIsArray(formData.columns).includes(col),
formDataOverrides: formData => {
const groupby = getStandardizedControls().controls.columns.filter(
col => !ensureIsArray(formData.columns).includes(col),
);
getStandardizedControls().controls.columns =
getStandardizedControls().controls.columns.filter(
col => !groupby.includes(col),
);
return {
...formData,
metrics: formData.standardizedFormData.standardizedState.metrics,
metrics: getStandardizedControls().popAllMetrics(),
groupby,
};
},