QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(standardized form data): refine interface and improve code smells (#20518)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-06-28 21:09:42 +08:00
committed by GitHub
parent 23e62d3782
commit c348a095b9
34 changed files with 580 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
View File

@@ -32,6 +32,7 @@ import {
sharedControls,
emitFilterControl,
Dataset,
getStandardizedControls,
} from '@superset-ui/chart-controls';
import { MetricsLayoutEnum } from '../types';
@@ -373,14 +374,17 @@ const config: ControlPanelConfig = {
],
},
],
denormalizeFormData: formData => {
const groupbyColumns =
formData.standardizedFormData.standardizedState.columns.filter(
col => !ensureIsArray(formData.groupbyRows).includes(col),
formDataOverrides: formData => {
const groupbyColumns = getStandardizedControls().controls.columns.filter(
col => !ensureIsArray(formData.groupbyRows).includes(col),
);
getStandardizedControls().controls.columns =
getStandardizedControls().controls.columns.filter(
col => !groupbyColumns.includes(col),
);
return {
...formData,
metrics: formData.standardizedFormData.standardizedState.metrics,
metrics: getStandardizedControls().popAllMetrics(),
groupbyColumns,
};
},