QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-09 03:16:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(sql_parse): Provide more meaningful SQLGlot errors (#27858)

Browse Source
This commit is contained in:
John Bodley
2024-04-03 07:10:52 -07:00
committed by GitHub
parent 848a7ffbf3
commit c38529741e
2 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit_tests/sql_parse_tests.py
View File

@@ -277,26 +277,30 @@ def test_extract_tables_illdefined() -> None:
with pytest.raises(SupersetSecurityException) as excinfo:
extract_tables("SELECT * FROM schemaname.")
assert (
str(excinfo.value) == "Unable to parse SQL (generic): SELECT * FROM schemaname."
str(excinfo.value)
== "You may have an error in your SQL statement. Error parsing near '.' at line 1:25"
)
with pytest.raises(SupersetSecurityException) as excinfo:
extract_tables("SELECT * FROM catalogname.schemaname.")
assert (
str(excinfo.value)
== "Unable to parse SQL (generic): SELECT * FROM catalogname.schemaname."
== "You may have an error in your SQL statement. Error parsing near '.' at line 1:37"
)
with pytest.raises(SupersetSecurityException) as excinfo:
extract_tables("SELECT * FROM catalogname..")
assert (
str(excinfo.value)
== "Unable to parse SQL (generic): SELECT * FROM catalogname.."
== "You may have an error in your SQL statement. Error parsing near '.' at line 1:27"
)
with pytest.raises(SupersetSecurityException) as excinfo:
extract_tables('SELECT * FROM "tbname')
assert str(excinfo.value) == 'Unable to parse SQL (generic): SELECT * FROM "tbname'
assert (
str(excinfo.value)
== "You may have an error in your SQL statement. Error tokenizing 'SELECT * FROM \"tbnam'"
)
# odd edge case that works
assert extract_tables("SELECT * FROM catalogname..tbname") == {