mirror of
https://github.com/apache/superset.git
synced 2026-04-22 17:45:21 +00:00
feat(dashboard): direct link to single chart/tab/header in dashboard (#6964)
* direct display for pre-selected tab * update parents * add AnchorLink component * add unit tests
This commit is contained in:
@@ -0,0 +1,100 @@
|
||||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
import sinon from 'sinon';
|
||||
import { SupersetClient } from '@superset-ui/connection';
|
||||
|
||||
import { saveDashboardRequest } from '../../../../src/dashboard/actions/dashboardState';
|
||||
import { UPDATE_COMPONENTS_PARENTS_LIST } from '../../../../src/dashboard/actions/dashboardLayout';
|
||||
import mockDashboardData from '../fixtures/mockDashboardData';
|
||||
import { DASHBOARD_GRID_ID } from '../../../../src/dashboard/util/constants';
|
||||
|
||||
describe('dashboardState actions', () => {
|
||||
const mockState = {
|
||||
dashboardState: {
|
||||
hasUnsavedChanges: true,
|
||||
},
|
||||
dashboardInfo: {},
|
||||
dashboardLayout: {
|
||||
past: [],
|
||||
present: mockDashboardData.positions,
|
||||
future: {},
|
||||
},
|
||||
};
|
||||
const newDashboardData = mockDashboardData;
|
||||
|
||||
let postStub;
|
||||
beforeEach(() => {
|
||||
postStub = sinon
|
||||
.stub(SupersetClient, 'post')
|
||||
.resolves('the value you want to return');
|
||||
});
|
||||
afterEach(() => {
|
||||
postStub.restore();
|
||||
});
|
||||
|
||||
function setup(stateOverrides) {
|
||||
const state = { ...mockState, ...stateOverrides };
|
||||
const getState = sinon.spy(() => state);
|
||||
const dispatch = sinon.stub();
|
||||
return { getState, dispatch, state };
|
||||
}
|
||||
|
||||
describe('saveDashboardRequest', () => {
|
||||
it('should dispatch UPDATE_COMPONENTS_PARENTS_LIST action', () => {
|
||||
const { getState, dispatch } = setup({
|
||||
dashboardState: { hasUnsavedChanges: false },
|
||||
});
|
||||
const thunk = saveDashboardRequest(newDashboardData, 1, 'save_dash');
|
||||
thunk(dispatch, getState);
|
||||
expect(dispatch.callCount).toBe(1);
|
||||
expect(dispatch.getCall(0).args[0].type).toBe(
|
||||
UPDATE_COMPONENTS_PARENTS_LIST,
|
||||
);
|
||||
});
|
||||
|
||||
it('should post dashboard data with updated redux state', () => {
|
||||
const { getState, dispatch } = setup({
|
||||
dashboardState: { hasUnsavedChanges: false },
|
||||
});
|
||||
|
||||
// start with mockDashboardData, it didn't have parents attr
|
||||
expect(
|
||||
newDashboardData.positions[DASHBOARD_GRID_ID].parents,
|
||||
).not.toBeDefined();
|
||||
|
||||
// mock redux work: dispatch an event, cause modify redux state
|
||||
const mockParentsList = ['ROOT_ID'];
|
||||
dispatch.callsFake(() => {
|
||||
mockState.dashboardLayout.present[
|
||||
DASHBOARD_GRID_ID
|
||||
].parents = mockParentsList;
|
||||
});
|
||||
|
||||
// call saveDashboardRequest, it should post dashboard data with updated
|
||||
// layout object (with parents attribute)
|
||||
const thunk = saveDashboardRequest(newDashboardData, 1, 'save_dash');
|
||||
thunk(dispatch, getState);
|
||||
expect(postStub.callCount).toBe(1);
|
||||
const postPayload = postStub.getCall(0).args[0].postPayload;
|
||||
expect(postPayload.data.positions[DASHBOARD_GRID_ID].parents).toBe(
|
||||
mockParentsList,
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user