QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: flacky test in test_update_dataset_item_w_override_columns (#14082)

Browse Source 
* fix flack test

* fix flack test
This commit is contained in:
Hugh A. Miles II
2021-04-12 16:45:50 -04:00
committed by GitHub
parent 7980b767c0
commit c563ea091e
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/datasets/api_tests.py
View File

@@ -582,16 +582,15 @@ class TestDatasetApi(SupersetTestCase):
# Add default dataset
dataset = self.insert_default_dataset()
self.login(username="admin")
new_col_dict = {
"column_name": "new_col",
"description": "description",
"expression": "expression",
"type": "INTEGER",
"verbose_name": "New Col",
}
dataset_data = {
"columns": [
{
"column_name": "new_col",
"description": "description",
"expression": "expression",
"type": "INTEGER",
"verbose_name": "New Col",
}
],
"columns": [new_col_dict],
"description": "changed description",
}
uri = f"api/v1/dataset/{dataset.id}?override_columns=true"
@@ -600,10 +599,10 @@ class TestDatasetApi(SupersetTestCase):
columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
assert columns[0].column_name == dataset_data["columns"][0]["column_name"]
assert columns[0].description == dataset_data["columns"][0]["description"]
assert columns[0].expression == dataset_data["columns"][0]["expression"]
assert columns[0].type == dataset_data["columns"][0]["type"]
assert new_col_dict["column_name"] in [col.column_name for col in columns]
assert new_col_dict["description"] in [col.description for col in columns]
assert new_col_dict["expression"] in [col.expression for col in columns]
assert new_col_dict["type"] in [col.type for col in columns]
db.session.delete(dataset)
db.session.commit()