QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-25 02:55:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Drill to Detail for Embedded (#39214)

Browse Source 
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Vitor Avila
2026-04-09 17:01:48 -03:00
committed by GitHub
parent 68067d7f44
commit c7955a38ef
6 changed files with 188 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/integration_tests/datasource_tests.py
View File

@@ -24,7 +24,7 @@ import prison
import pytest
from flask import current_app
from superset import db
from superset import db, security_manager as sm
from superset.commands.dataset.exceptions import DatasetNotFoundError
from superset.common.utils.query_cache_manager import QueryCacheManager
from superset.connectors.sqla.models import ( # noqa: F401
@@ -531,17 +531,26 @@ class TestDatasource(SupersetTestCase):
self, mock_has_guest_access, mock_is_guest_user, mock_rls
):
"""
Embedded user can access the /samples view.
Embedded guest user can access /samples (for D2D) via the dashboard context
passed as form_data to QueryContextFactory.
"""
self.login(ADMIN_USERNAME)
# Gamma role doesn't have dataset access (mimic embedded role),
# but needs access to the /samples endpoint
gamma_role = sm.find_role("Gamma")
perm_view = sm.find_permission_view_menu("can_samples", "Datasource")
sm.add_permission_role(gamma_role, perm_view)
self.login(GAMMA_USERNAME)
mock_is_guest_user.return_value = True
mock_has_guest_access.return_value = True
mock_rls.return_value = []
tbl = self.get_table(name="birth_names")
dash = self.get_dash_by_slug("births")
uri = f"/datasource/samples?datasource_id={tbl.id}&datasource_type=table&dashboard_id={dash.id}" # noqa: E501
resp = self.client.post(uri, json={})
assert resp.status_code == 200
try:
uri = f"/datasource/samples?datasource_id={tbl.id}&datasource_type=table&dashboard_id={dash.id}" # noqa: E501
resp = self.client.post(uri, json={})
assert resp.status_code == 200
finally:
sm.del_permission_role(gamma_role, perm_view)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
@mock.patch(