QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: make user agent customizable (#32506)

Browse Source
This commit is contained in:
Ville Brofeldt
2025-03-05 16:33:24 -08:00
committed by GitHub
parent 8decc9e45f
commit c90e45a373
18 changed files with 101 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset/db_engine_specs/duckdb.py
View File

@@ -30,13 +30,13 @@ from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.engine.url import URL
from superset.config import VERSION_STRING
from superset.constants import TimeGrain, USER_AGENT
from superset.constants import TimeGrain
from superset.databases.utils import make_url_safe
from superset.db_engine_specs.base import BaseEngineSpec
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.utils.core import get_user_agent, QuerySource
if TYPE_CHECKING:
# prevent circular imports
from superset.models.core import Database
@@ -237,7 +237,9 @@ class DuckDBEngineSpec(DuckDBParametersMixin, BaseEngineSpec):
return set(inspector.get_table_names(schema))
@staticmethod
def get_extra_params(database: Database) -> dict[str, Any]:
def get_extra_params(
database: Database, source: QuerySource | None = None
) -> dict[str, Any]:
"""
Add a user agent to be used in the requests.
"""
@@ -247,7 +249,8 @@ class DuckDBEngineSpec(DuckDBParametersMixin, BaseEngineSpec):
config: dict[str, Any] = connect_args.setdefault("config", {})
custom_user_agent = config.pop("custom_user_agent", "")
delim = " " if custom_user_agent else ""
user_agent = USER_AGENT.replace(" ", "-").lower()
user_agent = get_user_agent(database, source)
user_agent = user_agent.replace(" ", "-").lower()
user_agent = f"{user_agent}/{VERSION_STRING}{delim}{custom_user_agent}"
config.setdefault("custom_user_agent", user_agent)