QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-16 22:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(histogram): add NULL handling for histogram (#35693)

Browse Source 
Co-authored-by: Rachel Pan <r.pan@mail.utoronto.ca>
Co-authored-by: Rachel Pan <panrrachel@gmail.com>
Co-authored-by: Janani Gurram <68124448+JG-ctrl@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Janani Gurram
2025-11-14 14:54:13 -05:00
committed by GitHub
parent e6a5616543
commit c955a5dc08
2 changed files with 72 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
tests/unit_tests/pandas_postprocessing/test_histogram.py
View File

@@ -140,3 +140,70 @@ def test_histogram_with_some_non_numeric_values():
histogram(data_with_non_numeric, "a", ["group"], bins)
except ValueError as e:
assert str(e) == "Column 'group' contains non-numeric values" # noqa: PT017
def test_histogram_with_groupby_and_some_null_values():
data_with_groupby_and_some_nulls = DataFrame(
{
"group": ["A", "A", "B", "B", "A", "A", "B", "B", "A", "A"],
"a": [1, 2, 3, 4, 5, None, 7, 8, 9, 10],
"b": [1, 2, 3, 4, 5, None, 7, 8, 9, 10],
}
)
result = histogram(data_with_groupby_and_some_nulls, "a", ["group"], bins)
assert result.shape == (2, bins + 1)
assert result.columns.tolist() == [
"group",
"1.0 - 2.8",
"2.8 - 4.6",
"4.6 - 6.4",
"6.4 - 8.2",
"8.2 - 10.0",
]
assert result.values.tolist() == [["A", 2, 0, 1, 0, 2], ["B", 0, 2, 0, 2, 0]]
def test_histogram_with_no_groupby_and_some_null_values():
data_with_no_groupby_and_some_nulls = DataFrame(
{
"a": [1, 2, 3, 4, 5, None, 7, 8, 9, 10],
"b": [1, 2, 3, 4, 5, None, 7, 8, 9, 10],
}
)
result = histogram(data_with_no_groupby_and_some_nulls, "a", [], bins)
assert result.shape == (1, bins)
assert result.columns.tolist() == [
"1.0 - 2.8",
"2.8 - 4.6",
"4.6 - 6.4",
"6.4 - 8.2",
"8.2 - 10.0",
]
assert result.values.tolist() == [[2, 2, 1, 2, 2]]
def test_histogram_with_groupby_and_all_null_values():
data_with_groupby_and_all_nulls = DataFrame(
{
"group": ["A", "A", "B", "B", "A", "A", "B", "B", "A", "A"],
"a": [None, None, None, None, None, None, None, None, None, None],
"b": [None, None, None, None, None, None, None, None, None, None],
}
)
result = histogram(data_with_groupby_and_all_nulls, "a", ["group"], bins)
assert result.empty
def test_histogram_with_no_groupby_and_all_null_values():
data_with_no_groupby_and_all_nulls = DataFrame(
{
"a": [None, None, None, None, None, None, None, None, None, None],
"b": [None, None, None, None, None, None, None, None, None, None],
}
)
result = histogram(data_with_no_groupby_and_all_nulls, "a", [], bins)
assert result.empty