QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Revert "fix: don't strip SQL comments in Explore (#28363)" (#28567)

Browse Source
This commit is contained in:
Michael S. Molina
2024-05-17 15:01:23 -03:00
committed by GitHub
parent a2947d0c23
commit c9aa4a1f84
7 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/integration_tests/datasource_tests.py
View File

@@ -538,12 +538,10 @@ def test_get_samples(test_client, login_as_admin, virtual_dataset):
assert "coltypes" in rv2.json["result"]
assert "data" in rv2.json["result"]
sql = (
f"select * from ({virtual_dataset.sql}) as tbl "
f'limit {app.config["SAMPLES_ROW_LIMIT"]}'
eager_samples = virtual_dataset.database.get_df(
f"select * from ({virtual_dataset.sql}) as tbl"
f' limit {app.config["SAMPLES_ROW_LIMIT"]}'
)
eager_samples = virtual_dataset.database.get_df(sql)
# the col3 is Decimal
eager_samples["col3"] = eager_samples["col3"].apply(float)
eager_samples = eager_samples.to_dict(orient="records")