chore: remove deprecated apis copy_dash, save_dash and add_slices (#24353)

tests/integration_tests/dashboards/base_case.py

@@ -14,8 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-import json
-from typing import Any, Union
 
 import prison
 from flask import Response
@@ -48,17 +46,6 @@ class DashboardTestCase(SupersetTestCase):
     def get_dashboards_api_response(self) -> Response:
         return self.client.get(DASHBOARDS_API_URL)
 
-    def save_dashboard_via_view(
-        self, dashboard_id: Union[str, int], dashboard_data: dict[str, Any]
-    ) -> Response:
-        save_dash_url = SAVE_DASHBOARD_URL_FORMAT.format(dashboard_id)
-        return self.get_resp(save_dash_url, data=dict(data=json.dumps(dashboard_data)))
-
-    def save_dashboard(
-        self, dashboard_id: Union[str, int], dashboard_data: dict[str, Any]
-    ) -> Response:
-        return self.save_dashboard_via_view(dashboard_id, dashboard_data)
-
     def delete_dashboard_via_view(self, dashboard_id: int) -> Response:
         delete_dashboard_url = DELETE_DASHBOARD_VIEW_URL_FORMAT.format(dashboard_id)
         return self.get_resp(delete_dashboard_url, {})
@@ -90,26 +77,6 @@ class DashboardTestCase(SupersetTestCase):
         view_menu = security_manager.find_view_menu(deleted_dashboard.view_name)
         self.assertIsNone(view_menu)
 
-    def save_dash_basic_case(self, username=ADMIN_USERNAME):
-        # arrange
-        self.login(username=username)
-        (
-            dashboard_to_save,
-            data_before_change,
-            data_after_change,
-        ) = build_save_dash_parts()
-
-        # act
-        save_dash_response = self.save_dashboard_via_view(
-            dashboard_to_save.id, data_after_change
-        )
-
-        # assert
-        self.assertIn("SUCCESS", save_dash_response)
-
-        # post test
-        self.save_dashboard(dashboard_to_save.id, data_before_change)
-
     def clean_created_objects(self):
         with app.test_request_context():
             self.logout()

tests/integration_tests/dashboards/consts.py

@@ -24,8 +24,6 @@ EXPORT_DASHBOARDS_API_URL = DASHBOARDS_API_URL + "export/"
 EXPORT_DASHBOARDS_API_URL_WITH_QUERY_FORMAT = EXPORT_DASHBOARDS_API_URL + QUERY_FORMAT
 
 GET_DASHBOARD_VIEW_URL_FORMAT = "/superset/dashboard/{}/"
-SAVE_DASHBOARD_URL_FORMAT = "/superset/save_dash/{}/"
-ADD_SLICES_URL_FORMAT = "/superset/add_slices/{}/"
 
 DELETE_DASHBOARD_VIEW_URL_FORMAT = "/dashboard/delete/{}"
 GET_DASHBOARDS_LIST_VIEW = "/dashboard/list/"