fix: Update dataset's last modified date from column/metric update (#33626)

This commit is contained in:
Vitor Avila
2025-06-03 12:20:38 -03:00
committed by GitHub
parent fa0c5891bf
commit cacf1e06d6
6 changed files with 149 additions and 38 deletions

View File

@@ -17,6 +17,7 @@
from __future__ import annotations
import unittest
from datetime import timedelta
from io import BytesIO
from unittest.mock import ANY, patch
from zipfile import is_zipfile, ZipFile
@@ -24,6 +25,7 @@ from zipfile import is_zipfile, ZipFile
import prison
import pytest
import yaml
from freezegun import freeze_time
from sqlalchemy import inspect
from sqlalchemy.exc import SQLAlchemyError
from sqlalchemy.orm import joinedload
@@ -1144,9 +1146,9 @@ class TestDatasetApi(SupersetTestCase):
"""
Dataset API: Test update dataset create column
"""
# create example dataset by Command
dataset = self.insert_default_dataset()
current_changed_on = dataset.changed_on
new_column_data = {
"column_name": "new_col",
@@ -1188,13 +1190,16 @@ class TestDatasetApi(SupersetTestCase):
metric.pop("type_generic", None)
data["result"]["metrics"].append(new_metric_data)
rv = self.client.put(
uri,
json={
"columns": data["result"]["columns"],
"metrics": data["result"]["metrics"],
},
)
with freeze_time() as frozen:
frozen.tick(delta=timedelta(seconds=3))
rv = self.client.put(
uri,
json={
"columns": data["result"]["columns"],
"metrics": data["result"]["metrics"],
},
)
assert rv.status_code == 200
@@ -1233,6 +1238,10 @@ class TestDatasetApi(SupersetTestCase):
assert metrics[1].warning_text == new_metric_data["warning_text"]
assert str(metrics[1].uuid) == new_metric_data["uuid"]
# Validate that the changed_on is updated
updated_dataset = db.session.query(SqlaTable).filter_by(id=dataset.id).first()
assert updated_dataset.changed_on > current_changed_on
self.items_to_delete = [dataset]
def test_update_dataset_delete_column(self):