mirror of
https://github.com/apache/superset.git
synced 2026-04-19 08:04:53 +00:00
chore: proper current_app.config proxy usage (#34345)
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
committed by
GitHub
parent
6c9cda758a
commit
cb27d5fe8d
@@ -19,9 +19,10 @@ from __future__ import annotations
|
||||
import logging
|
||||
from typing import Any, TypedDict
|
||||
|
||||
from flask import current_app as app
|
||||
from flask_babel import gettext as __
|
||||
|
||||
from superset import app, db
|
||||
from superset import db
|
||||
from superset.commands.base import BaseCommand
|
||||
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
|
||||
from superset.exceptions import SupersetErrorException, SupersetTimeoutException
|
||||
@@ -29,10 +30,6 @@ from superset.jinja_context import get_template_processor
|
||||
from superset.models.core import Database
|
||||
from superset.utils import core as utils
|
||||
|
||||
config = app.config
|
||||
SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT = config["SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT"]
|
||||
stats_logger = config["STATS_LOGGER"]
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
|
||||
@@ -81,7 +78,7 @@ class QueryEstimationCommand(BaseCommand):
|
||||
template_processor = get_template_processor(self._database)
|
||||
sql = template_processor.process_template(sql, **self._template_params)
|
||||
|
||||
timeout = SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT
|
||||
timeout = app.config["SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT"]
|
||||
timeout_msg = f"The estimation exceeded the {timeout} seconds timeout."
|
||||
try:
|
||||
with utils.timeout(seconds=timeout, error_message=timeout_msg):
|
||||
@@ -100,7 +97,7 @@ class QueryEstimationCommand(BaseCommand):
|
||||
"The query estimation was killed after %(sqllab_timeout)s "
|
||||
"seconds. It might be too complex, or the database might be "
|
||||
"under heavy load.",
|
||||
sqllab_timeout=SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT,
|
||||
sqllab_timeout=app.config["SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT"],
|
||||
),
|
||||
error_type=SupersetErrorType.SQLLAB_TIMEOUT_ERROR,
|
||||
level=ErrorLevel.ERROR,
|
||||
|
||||
Reference in New Issue
Block a user