QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 15:15:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: proper current_app.config proxy usage (#34345)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2025-07-31 19:27:42 -07:00
committed by GitHub
parent 6c9cda758a
commit cb27d5fe8d
144 changed files with 1428 additions and 1119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
superset/common/utils/query_cache_manager.py
View File

@@ -19,10 +19,10 @@ from __future__ import annotations
import logging
from typing import Any
from flask import current_app
from flask_caching import Cache
from pandas import DataFrame
from superset import app
from superset.common.db_query_status import QueryStatus
from superset.constants import CacheRegion
from superset.exceptions import CacheLoadError
@@ -33,8 +33,6 @@ from superset.superset_typing import Column
from superset.utils.cache import set_and_log_cache
from superset.utils.core import error_msg_from_exception, get_stacktrace
config = app.config
stats_logger: BaseStatsLogger = config["STATS_LOGGER"]
logger = logging.getLogger(__name__)
_cache: dict[CacheRegion, Cache] = {
@@ -48,6 +46,10 @@ class QueryCacheManager:
Class for manage query-cache getting and setting
"""
@property
def stats_logger(self) -> BaseStatsLogger:
return current_app.config["STATS_LOGGER"]
# pylint: disable=too-many-instance-attributes,too-many-arguments
def __init__(
self,
@@ -108,9 +110,11 @@ class QueryCacheManager:
self.annotation_data = {} if annotation_data is None else annotation_data
if self.status != QueryStatus.FAILED:
stats_logger.incr("loaded_from_source")
current_app.config["STATS_LOGGER"].incr("loaded_from_source")
if not force_query:
stats_logger.incr("loaded_from_source_without_force")
current_app.config["STATS_LOGGER"].incr(
"loaded_from_source_without_force"
)
self.is_loaded = True
value = {
@@ -154,7 +158,7 @@ class QueryCacheManager:
if cache_value := _cache[region].get(key):
logger.debug("Cache key: %s", key)
stats_logger.incr("loading_from_cache")
current_app.config["STATS_LOGGER"].incr("loading_from_cache")
try:
query_cache.df = cache_value["df"]
query_cache.query = cache_value["query"]
@@ -176,7 +180,7 @@ class QueryCacheManager:
cache_value["dttm"] if cache_value is not None else None
)
query_cache.cache_value = cache_value
stats_logger.incr("loaded_from_cache")
current_app.config["STATS_LOGGER"].incr("loaded_from_cache")
except KeyError as ex:
logger.exception(ex)
logger.error(