chore: proper current_app.config proxy usage (#34345)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2025-07-31 19:27:42 -07:00
committed by GitHub
parent 6c9cda758a
commit cb27d5fe8d
144 changed files with 1428 additions and 1119 deletions

View File

@@ -35,7 +35,8 @@ from sqlalchemy.engine.url import make_url
from sqlalchemy.types import DateTime # noqa: F401
import tests.integration_tests.test_app # noqa: F401
from superset import app, db as metadata_db
from flask import current_app
from superset import db as metadata_db
from superset.db_engine_specs.postgres import PostgresEngineSpec # noqa: F401
from superset.common.db_query_status import QueryStatus
from superset.models.core import Database
@@ -523,11 +524,11 @@ class TestSqlaTableModel(SupersetTestCase):
def mutator(*args, **kwargs):
return "-- COMMENT\n" + args[0]
app.config["SQL_QUERY_MUTATOR"] = mutator
current_app.config["SQL_QUERY_MUTATOR"] = mutator
sql = tbl.get_query_str(query_obj)
assert "-- COMMENT" in sql
app.config["SQL_QUERY_MUTATOR"] = None
current_app.config["SQL_QUERY_MUTATOR"] = None
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_sql_mutator_different_params(self):
@@ -549,12 +550,12 @@ class TestSqlaTableModel(SupersetTestCase):
def mutator(sql, database=None, **kwargs):
return "-- COMMENT\n--" + "\n" + str(database) + "\n" + sql
app.config["SQL_QUERY_MUTATOR"] = mutator
current_app.config["SQL_QUERY_MUTATOR"] = mutator
mutated_sql = tbl.get_query_str(query_obj)
assert "-- COMMENT" in mutated_sql
assert tbl.database.name in mutated_sql
app.config["SQL_QUERY_MUTATOR"] = None
current_app.config["SQL_QUERY_MUTATOR"] = None
def test_query_with_non_existent_metrics(self):
tbl = self.get_table(name="birth_names")